Skip to content

Use report_in_external_macro in internal lints #66370

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Centril opened this issue Nov 13, 2019 · 3 comments · Fixed by #67854
Closed

Use report_in_external_macro in internal lints #66370

Centril opened this issue Nov 13, 2019 · 3 comments · Fixed by #67854
Assignees
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Nov 13, 2019

Filing this since @eddyb had the idea and so that we don't forget.

This issue has been assigned to @afnanenayet via this comment.

@Centril Centril added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 13, 2019
@eddyb
Copy link
Member

eddyb commented Nov 13, 2019

cc @flip1995 @oli-obk

@oli-obk oli-obk added C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Nov 27, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Nov 27, 2019

It should be as easy (unless I'm overlooking something) as adding report_in_external_macro: true to all declare_tool_lint invocations

declare_tool_lint! {
and then fixing the fallout (changing imports as described by the lint)

@afnanenayet
Copy link
Contributor

I'd like to handle this

@rustbot claim

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants