Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Extend bindings_after_at (b1 @ Some(b2)) tests with nested or_patterns #67311

Closed
Centril opened this issue Dec 15, 2019 · 5 comments · Fixed by #69817
Closed

Extend bindings_after_at (b1 @ Some(b2)) tests with nested or_patterns #67311

Centril opened this issue Dec 15, 2019 · 5 comments · Fixed by #69817
Assignees
@rustbot
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. F-bindings_after_at `#![feature(bindings_after_at)]` F-or_patterns `#![feature(or_patterns)]` F-slice_patterns `#![feature(slice_patterns)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Dec 15, 2019 •
edited by rustbot
Loading

Once #![feature(or_patterns)] (#54883), i.e. pat_0 | ... | pat_n in nested positions, e.g. Some(Ok(a) | Err(b)) have progressed sufficiently in their implementation, e.g. when the MIR building implementation is done, we should extend the test suite for #![feature(bindings_after_at)] (#65490), e.g. b1 @ Some(b2), to exercise the combination of these two features. Ideally, we would also account for the combination of those two with #![feature(slice_patterns)] (#62254) and #![feature(box_patterns)] (#29641) as well to make things really air-tight.

This issue has been assigned to @thekuom via this comment.
@Centril Centril added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. S-blocked Status: Blocked on something else such as an RFC or other implementation work. F-or_patterns `#![feature(or_patterns)]` F-bindings_after_at `#![feature(bindings_after_at)]` F-slice_patterns `#![feature(slice_patterns)]` labels Dec 15, 2019
@Centril Centril mentioned this issue Dec 21, 2019
Closed
8 tasks
@Centril
Copy link
Contributor Author

Centril commented Dec 24, 2019

This is almost unblocked now that #66296 has landed. However, we need more progress on or-patterns.

@JohnTitor JohnTitor added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jan 19, 2020
@Centril Centril removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Feb 14, 2020
@thekuom
Copy link
Contributor

thekuom commented Mar 4, 2020

Can I work on this one?

@Centril

This comment has been minimized.

# to view
@rustbot

This comment has been minimized.

# to view
@Centril
Copy link
Contributor Author

Centril commented Mar 4, 2020 •
edited
Loading

Sure, go right ahead.

@rustbot assign @thekuom

@rustbot rustbot assigned rustbot and unassigned rustbot Mar 4, 2020
thekuom added a commit to thekuom/rust that referenced this issue Mar 4, 2020
@thekuom
test(pattern): add tests for combinations of pattern features
5456114 
Reference issue rust-lang#67311

Tests combinations of the following pattern features:
- bindings_after_at
- or_patterns
- slice_patterns
- box_patterns
@thekuom thekuom mentioned this issue Mar 4, 2020
Merged
Centril added a commit to Centril/rust that referenced this issue Mar 7, 2020
@Centril
Rollup merge of rust-lang#69690 - thekuom:test/67311-extend-bindings-…
4f87d9f 
…after-at-tests, r=Centril

test(pattern): add tests for combinations of pattern features

Reference issue rust-lang#67311

Tests combinations of the following pattern features:
- bindings_after_at
- or_patterns
- slice_patterns
- box_patterns

r? @Centril
Centril added a commit to Centril/rust that referenced this issue Mar 7, 2020
@Centril
Rollup merge of rust-lang#69690 - thekuom:test/67311-extend-bindings-…
ba1f6cb 
…after-at-tests, r=Centril

test(pattern): add tests for combinations of pattern features

Reference issue rust-lang#67311

Tests combinations of the following pattern features:
- bindings_after_at
- or_patterns
- slice_patterns
- box_patterns

r? @Centril
@thekuom thekuom mentioned this issue Mar 9, 2020
Merged
@bors bors closed this as completed in 08095f4 Mar 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rustbot rustbot

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. F-bindings_after_at `#![feature(bindings_after_at)]` F-or_patterns `#![feature(or_patterns)]` F-slice_patterns `#![feature(slice_patterns)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(patterns): add patterns feature tests to borrowck test suite thekuom/rust
4 participants
@Centril @thekuom @JohnTitor @rustbot