Skip to content

Rust port of criterion for benchmarking #6812

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
graydon opened this issue May 29, 2013 · 6 comments
Closed

Rust port of criterion for benchmarking #6812

graydon opened this issue May 29, 2013 · 6 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@graydon
Copy link
Contributor

graydon commented May 29, 2013

The built in unit tester presently contains some very crude one-off automated benchmarking stuff. It was initially a clone of the Go testing.B benchmark system (http://golang.org/pkg/testing/#B) but started to drift towards doing statistical measurement in order to get a more stable signal.

I believe Bryan O'Sullivan's criterion library (https://github.com/bos/criterion) is the state of the art here. We should port / emulate whatever it does well.

@catamorphism
Copy link
Contributor

(bug triage) Good idea; not a blocker IMO.

@Aatch
Copy link
Contributor

Aatch commented Mar 4, 2014

Visiting for triage.

This would be nice, but still isn't a high-priority.

@schuster
Copy link

schuster commented Apr 5, 2014

I thought I might try to write this to help me learn Rust. I've found the testing guide and the various benchmark tests in the code. Are there any other resources I should be aware of, or design goals to keep in mind (other than emulating criterion)?

I'll try to get something simple working, post it, and request feedback as I go.

@japaric
Copy link
Member

japaric commented May 26, 2014

I'm tackling this issue here, I'll love to get feedback!

@kud1ing
Copy link

kud1ing commented Oct 16, 2014

Is this fixed by https://github.com/japaric/criterion.rs ?
Is it already usable for supporting #18085 ?

@steveklabnik
Copy link
Member

I'm pulling a massive triage effort to get us ready for 1.0. As part of this, I'm moving stuff that's wishlist-like to the RFCs repo, as that's where major new things should get discussed/prioritized.

This issue has been moved to the RFCs repo: rust-lang/rfcs#651

flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 11, 2021
Fix ICEs 6792 and 6793

fixes rust-lang#6792, fixes rust-lang#6793.
r? `@matthiaskrgr`

Fixes the ICEs by replacing `TyCtxt::type_of` with `TypeckResults::expr_ty`.

changelog: none
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

7 participants