Skip to content

vec::any calls in ty_struct cases in ty.rs should be vec::all #6868

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
bblum opened this issue May 31, 2013 · 1 comment
Closed

vec::any calls in ty_struct cases in ty.rs should be vec::all #6868

bblum opened this issue May 31, 2013 · 1 comment
Labels
A-type-system Area: Type system E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bblum
Copy link
Contributor

bblum commented May 31, 2013

For example, this is clearly wrong in type_is_pod:

2515       ty_struct(did, ref substs) => {
2516         result = vec::any(lookup_struct_fields(cx, did), |f| {
2517             let fty = ty::lookup_item_type(cx, f.id);
2518             let sty = subst(cx, substs, fty.ty);
2519             type_is_pod(cx, sty)
2520         });
2521       }

But vec::any is called in other places throughout this file and I'm not immediately sure which ones are right vs wrong.

@catamorphism
Copy link
Contributor

The other calls to any look fine. It's just that one that's wrong (my mistake).

@ghost ghost assigned msullivan Jun 3, 2013
msullivan added a commit to msullivan/rust that referenced this issue Jun 4, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 11, 2021
Don't assume lang items will exist.

~~Should fix lintcheck warnings caused by rust-lang#6823~~
See below

changelog: None
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-type-system Area: Type system E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants