Skip to content

compiletest: issue error on compile-fail in UI tests #68732

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Centril opened this issue Feb 1, 2020 · 1 comment · Fixed by #68760
Closed

compiletest: issue error on compile-fail in UI tests #68732

Centril opened this issue Feb 1, 2020 · 1 comment · Fixed by #68760
Assignees
@rustbot
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Feb 1, 2020 •
edited by rustbot
Loading

Context: #68728 (comment).

In src/test/ui we should not allow:

// compile-fail

/* stuff */

This issue has been assigned to @Tyg13 via this comment.
@Centril Centril added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 1, 2020
@Centril Centril mentioned this issue Feb 1, 2020
Merged
@Tyg13
Copy link
Contributor

Tyg13 commented Feb 2, 2020

@rustbot claim

@rustbot rustbot self-assigned this Feb 2, 2020
@Tyg13 Tyg13 mentioned this issue Feb 2, 2020
Merged
Centril added a commit to Centril/rust that referenced this issue Feb 2, 2020
@Centril
Rollup merge of rust-lang#68760 - Tyg13:compile_fail_ui_test, r=Centril
5bc5590 
Issue error on `compile-fail` header in UI test

Fixes rust-lang#68732

r? @Centril
@bors bors closed this as completed in 3a7f1ed Feb 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rustbot rustbot

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue error on compile-fail header in UI test Tyg13/rust
3 participants
@Tyg13 @Centril @rustbot