Skip to content

miri no longer builds after rust-lang/rust#69105 #69117

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
rust-highfive opened this issue Feb 13, 2020 · 1 comment · Fixed by #69162
Closed

miri no longer builds after rust-lang/rust#69105 #69117

rust-highfive opened this issue Feb 13, 2020 · 1 comment · Fixed by #69162
Assignees
@eddyb @RalfJung @oli-obk
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #69105, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Dylan-DPC, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Dylan-DPC, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 13, 2020
@RalfJung RalfJung mentioned this issue Feb 13, 2020
Merged
@nikomatsakis nikomatsakis added P-medium Medium priority and removed I-nominated labels Feb 13, 2020
@nikomatsakis
Copy link
Contributor

Triage meeting: Tagged as P-medium, appears to have PR.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 13, 2020
@Dylan-DPC
Rollup merge of rust-lang#69126 - RalfJung:exact-div, r=oli-obk
c8343b8 
miri: fix exact_div

Turns out `exact_div` was relying on the broken behavior of `Rem` for `int_min % -1` that was fixed in rust-lang#69002. This PR fixes `exact_div`.

Inside rustc, `exact_div` is only used in a single place where the divisor is always positive (in `ptr_offset_from`), so we cannot test the fix in rustc. The Miri test suite covers this through the `exact_div` intrinsic, though (and it is how I found out).

One step to rust-lang#69117 (then we also need to address build failures introduced by rust-lang#68969)

r? @oli-obk
@RalfJung RalfJung mentioned this issue Feb 14, 2020
Merged
@bors bors closed this as completed in e168dcd Feb 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update miri RalfJung/rust
5 participants
@eddyb @nikomatsakis @RalfJung @oli-obk @rust-highfive