Skip to content

Coloring for affected code underlining in the terminal ^~~~~~ #7164

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jeaye opened this issue Jun 15, 2013 · 1 comment · Fixed by #7230
Closed

Coloring for affected code underlining in the terminal ^~~~~~ #7164

jeaye opened this issue Jun 15, 2013 · 1 comment · Fixed by #7230

Comments

@jeaye
Copy link

jeaye commented Jun 15, 2013

'warning', 'note', and 'error' are colorized; I think it'd be nice to also colorize the underlining of the affected code, as clang does. clang makes it green, I believe.
@brson
Copy link
Contributor

brson commented Jun 16, 2013

+1 for doing whatever clang does re error reporting.

@Blei Blei mentioned this issue Jun 19, 2013
Merged
flip1995 pushed a commit to flip1995/rust that referenced this issue May 20, 2021
@bors
Auto merge of rust-lang#7188 - mgacek8:issue7164_needless_collect_FP,…
10db5a6 
… r=xFrednet,flip1995

`needless_collect` enhancements

fixes rust-lang#7164
changelog: `needless_collect`: For `BTreeMap` and `HashMap` lint only `is_empty`, as `len` might produce different results than iter's `count`
changelog: `needless_collect`: Lint `LinkedList` and `BinaryHeap` in direct usage case as well
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

syntax::diagnostics: Color the ^~~~ in green for better visibility
2 participants
@brson @jeaye