Skip to content

Tracking Issue for feature future_poll_fn #72302

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
2 tasks
yoshuawuyts opened this issue May 17, 2020 · 6 comments · Fixed by #99306
Closed
2 tasks

Tracking Issue for feature future_poll_fn #72302

yoshuawuyts opened this issue May 17, 2020 · 6 comments · Fixed by #99306
Labels
A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@yoshuawuyts
Copy link
Member

yoshuawuyts commented May 17, 2020 •
edited by JohnTitor
Loading

The feature gate for the issue is #![feature(future_poll_fn)].

Steps

Unresolved Questions

  • Should this be named future::from_fn instead?

Implementation history
@yoshuawuyts yoshuawuyts added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label May 17, 2020
@jonas-schievink jonas-schievink added A-async-await Area: Async & Await B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 17, 2020
@tmandry tmandry added the AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. label May 19, 2020
@KodrAus KodrAus added the Libs-Tracked Libs issues that are tracked on the team's project board. label Jul 29, 2020
@yoshuawuyts yoshuawuyts mentioned this issue Sep 16, 2020
Closed
@win-t win-t mentioned this issue Dec 1, 2020
Closed
@jplatte jplatte mentioned this issue Jan 7, 2021
Closed
@joshtriplett
Copy link
Member

This exists in futures-lite, and people use it. It seems worth having available in the standard library.

The naming discussion doesn't seem likely to change, and all else being equal there's a history for the name poll_fn.

Shall we stabilize this?

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 20, 2022 •
edited by BurntSushi
Loading

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 20, 2022
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jun 29, 2022
@rfcbot
Copy link
Collaborator

rfcbot commented Jun 29, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jun 29, 2022
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jul 9, 2022
@rfcbot
Copy link
Collaborator

rfcbot commented Jul 9, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Jul 9, 2022
@JohnTitor JohnTitor mentioned this issue Jul 16, 2022
Merged
@bors bors closed this as completed in 5052769 Jul 17, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 8, 2022
workingjubilee pushed a commit to tcdi/postgrestd that referenced this issue Sep 15, 2022
@JohnTitor
Rollup merge of #99306 - JohnTitor:stabilize-future-poll-fn, r=joshtr…
8c18a11 
…iplett

Stabilize `future_poll_fn`

FCP is done: rust-lang/rust#72302 (comment)
Closes #72302

r? `@joshtriplett` as you started FCP

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@RalfJung
Copy link
Member

RalfJung commented Oct 6, 2022 •
edited
Loading

There are some soundness issues with poll_fn (not strictly speaking a soundness bug, but we might still want to do a breaking change now before there are too many people relying on this): the fact that PollFn<F> is always Unpin is a problem. It should require F: Unpin for that.

See IRLO for details, in particular this miscompilation bug.

@RalfJung
Copy link
Member

RalfJung commented Oct 6, 2022

I am proposing to change the Unpin impl in #102737.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize future_poll_fn JohnTitor/rust
8 participants
@joshtriplett @RalfJung @jonas-schievink @tmandry @yoshuawuyts @apiraino @KodrAus @rfcbot