Skip to content

pretty/asm.rs test is failing on AArch64 #73134

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
pietroalbini opened this issue Jun 8, 2020 · 4 comments · Fixed by #73308
Closed

pretty/asm.rs test is failing on AArch64 #73134

pietroalbini opened this issue Jun 8, 2020 · 4 comments · Fixed by #73308
Assignees
@rustbot
Labels
A-inline-assembly Area: Inline assembly (`asm!(…)`) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state

Comments

@pietroalbini
Copy link
Member

pietroalbini commented Jun 8, 2020 •
edited by rustbot
Loading

The src/test/pretty/asm.rs test is failing on AArch64.

2020-06-08T14:19:35.3826793Z error: invalid register `al`: unknown register
2020-06-08T14:19:35.3827908Z   --> /checkout/src/test/pretty/asm.rs:17:18
2020-06-08T14:19:35.3828376Z    |
2020-06-08T14:19:35.3828948Z 17 |         asm!("", out("al") _, lateout("rbx") _);
2020-06-08T14:19:35.3829292Z    |                  ^^^^^^^^^^^
2020-06-08T14:19:35.3829460Z 
2020-06-08T14:19:35.3829755Z error: invalid register `rbx`: unknown register
2020-06-08T14:19:35.3830643Z   --> /checkout/src/test/pretty/asm.rs:17:31
2020-06-08T14:19:35.3831010Z    |
2020-06-08T14:19:35.3831309Z 17 |         asm!("", out("al") _, lateout("rbx") _);
2020-06-08T14:19:35.3831632Z    |                               ^^^^^^^^^^^^^^^^
2020-06-08T14:19:35.3831812Z 
2020-06-08T14:19:35.3832106Z error: aborting due to 2 previous errors

We should avoid having x86_64-specific registers in that test.

This issue has been assigned to @yerke via this comment.
@jonas-schievink jonas-schievink added A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state labels Jun 8, 2020
@pietroalbini
Copy link
Member Author

cc @Stammark @JamieCunliffe @vigoux @joaopaulocarreiro @raw-bin, this is one of the tests that are failing on AArch64.

@nagisa nagisa added the A-inline-assembly Area: Inline assembly (`asm!(…)`) label Jun 12, 2020
@nagisa
Copy link
Member

nagisa commented Jun 12, 2020

cc @Amanieu

@Amanieu
Copy link
Member

Amanieu commented Jun 12, 2020

I think it's just a matter of marking the test as // only-x86_64

@Amanieu Amanieu added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Jun 12, 2020
@yerke
Copy link
Contributor

yerke commented Jun 13, 2020

@rustbot claim

@rustbot rustbot self-assigned this Jun 13, 2020
@yerke yerke mentioned this issue Jun 13, 2020
Merged
RalfJung added a commit to RalfJung/rust that referenced this issue Jun 13, 2020
@RalfJung
Rollup merge of rust-lang#73308 - yerke:fix-pretty-asm-rs-test-for-aa…
6700a13 
…rch64, r=Amanieu

pretty/asm.rs should only be tested for x86_64 and not AArch64

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes rust-lang#73134
r?  @Amanieu
RalfJung added a commit to RalfJung/rust that referenced this issue Jun 13, 2020
@RalfJung
Rollup merge of rust-lang#73308 - yerke:fix-pretty-asm-rs-test-for-aa…
d63778d 
…rch64, r=Amanieu

pretty/asm.rs should only be tested for x86_64 and not AArch64

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes rust-lang#73134
r?  @Amanieu
RalfJung added a commit to RalfJung/rust that referenced this issue Jun 13, 2020
@RalfJung
Rollup merge of rust-lang#73308 - yerke:fix-pretty-asm-rs-test-for-aa…
dd43c02 
…rch64, r=Amanieu

pretty/asm.rs should only be tested for x86_64 and not AArch64

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes rust-lang#73134
r?  @Amanieu
RalfJung added a commit to RalfJung/rust that referenced this issue Jun 13, 2020
@RalfJung
Rollup merge of rust-lang#73308 - yerke:fix-pretty-asm-rs-test-for-aa…
ceb0d04 
…rch64, r=Amanieu

pretty/asm.rs should only be tested for x86_64 and not AArch64

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes rust-lang#73134
r?  @Amanieu
RalfJung added a commit to RalfJung/rust that referenced this issue Jun 13, 2020
@RalfJung
Rollup merge of rust-lang#73308 - yerke:fix-pretty-asm-rs-test-for-aa…
73d2c3e 
…rch64, r=Amanieu

pretty/asm.rs should only be tested for x86_64 and not AArch64

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes rust-lang#73134
r?  @Amanieu
@bors bors closed this as completed in 8d97ccf Jun 13, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rustbot rustbot

Labels
A-inline-assembly Area: Inline assembly (`asm!(…)`) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pretty/asm.rs should only be tested for x86_64 and not AArch64 yerke/rust
6 participants
@Amanieu @nagisa @jonas-schievink @pietroalbini @yerke @rustbot