ICE with the `@ ..` binding pattern #74539

r1fl · 2020-07-19T23:52:03Z

Code

pub enum Operands {
	Zero,
	One(u8),
	Two(u8, u8),
}

pub fn main() {
	use Operands::*;

	let operands = Zero;

	match operands {
		Zero => println!("Nothing"),
		One(operand) => println!("{:x}", operand),
		Two(operands @ ..) => println!("({:x}, {:x})", operands.0, operands.1),
	};
}

Error output

error: `operands @` is not allowed in a tuple struct
  --> ./a.rs:15:7
   |
15 |         Two(operands @ ..) => println!("({:x}, {:x})", operands.0, operands.1),
   |             ^^^^^^^^^^^^^ this is only allowed in slice patterns
   |
   = help: remove this and bind each tuple field independently
help: if you don't need to use the contents of operands, discard the tuple's remaining fields
   |
15 |         Two(..) => println!("({:x}, {:x})", operands.0, operands.1),
   |             ^^

error: internal compiler error: src/librustc_typeck/check/mod.rs:3023: no type for local variable unknown node (hir_id=HirId { owner: DefId(0:13 ~ a[317d]::main[0]), local_id: 9 })
  --> ./a.rs:15:50
   |
15 |         Two(operands @ ..) => println!("({:x}, {:x})", operands.0, operands.1),
   |                                                        ^^^^^^^^

thread 'rustc' panicked at 'Box<Any>', /rustc/5c1f21c3b82297671ad3ae1e8c942d2ca92e84f2/src/libstd/macros.rs:13:23
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Backtrace

thread 'rustc' panicked at 'Box<Any>', /rustc/5c1f21c3b82297671ad3ae1e8c942d2ca92e84f2/src/libstd/macros.rs:13:23
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.heygears.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.heygears.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:78
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1076
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1537
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:198
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:218
  10: rustc_driver::report_ice
  11: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:490
  12: std::panicking::begin_panic
  13: rustc_errors::HandlerInner::span_bug
  14: rustc_errors::Handler::span_bug
  15: rustc_middle::util::bug::opt_span_bug_fmt::{{closure}}
  16: rustc_middle::ty::context::tls::with_opt::{{closure}}
  17: rustc_middle::ty::context::tls::with_opt
  18: rustc_middle::util::bug::opt_span_bug_fmt
  19: rustc_middle::util::bug::span_bug_fmt
  20: rustc_typeck::check::FnCtxt::local_ty::{{closure}}
  21: rustc_typeck::check::FnCtxt::local_ty
  22: rustc_typeck::check::FnCtxt::instantiate_value_path
  23: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  24: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  25: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  26: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  27: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  28: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  29: <smallvec::SmallVec<A> as core::iter::traits::collect::Extend<<A as smallvec::Array>::Item>>::extend
  30: <T as rustc_middle::ty::context::InternIteratorElement<T,R>>::intern_with
  31: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  32: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  33: rustc_typeck::check::_match::<impl rustc_typeck::check::FnCtxt>::check_match
  34: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  35: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  36: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  37: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  38: rustc_typeck::check::FnCtxt::check_argument_types
  39: rustc_typeck::check::callee::<impl rustc_typeck::check::FnCtxt>::confirm_builtin_call
  40: rustc_typeck::check::callee::<impl rustc_typeck::check::FnCtxt>::check_call
  41: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  42: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  43: rustc_typeck::check::FnCtxt::check_argument_types
  44: rustc_typeck::check::callee::<impl rustc_typeck::check::FnCtxt>::confirm_builtin_call
  45: rustc_typeck::check::callee::<impl rustc_typeck::check::FnCtxt>::check_call
  46: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  47: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  48: rustc_typeck::check::FnCtxt::check_stmt
  49: rustc_typeck::check::FnCtxt::check_block_with_expected
  50: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  51: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  52: rustc_typeck::check::_match::<impl rustc_typeck::check::FnCtxt>::check_match
  53: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  54: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  55: rustc_typeck::check::FnCtxt::check_stmt
  56: rustc_typeck::check::FnCtxt::check_block_with_expected
  57: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_kind
  58: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_expr_with_expectation_and_needs
  59: rustc_typeck::check::expr::<impl rustc_typeck::check::FnCtxt>::check_return_expr
  60: rustc_typeck::check::check_fn
  61: rustc_middle::ty::context::GlobalCtxt::enter_local
  62: rustc_typeck::check::typeck_tables_of
  63: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::typeck_tables_of>::compute
  64: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  65: rustc_query_system::query::plumbing::get_query_impl
  66: rustc_query_system::query::plumbing::ensure_query_impl
  67: rustc_typeck::check::typeck_item_bodies
  68: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::typeck_item_bodies>::compute
  69: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  70: rustc_query_system::query::plumbing::get_query_impl
  71: rustc_typeck::check_crate
  72: rustc_interface::passes::analysis
  73: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccessors<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::analysis>::compute
  74: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
  75: rustc_query_system::query::plumbing::get_query_impl
  76: rustc_middle::ty::context::tls::enter_global
  77: rustc_interface::interface::run_compiler_in_existing_thread_pool
  78: rustc_ast::attr::with_globals
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

This issue has been assigned to @jakubadamw via this comment.

The text was updated successfully, but these errors were encountered:

matthiaskrgr · 2020-07-20T11:13:18Z

reduced:

enum E {
	A(u8),
}

fn fun(arg: E) {
	match arg {
		A(x @ ..) => {x}
	};
}

Edit: you can actually omit the enum declaration and it still crashes 🤔

fn fun(arg: E) {fn fun(arg: E) {
	match arg {
		A(x @ ..) => {x}
	};
}

jakubadamw · 2020-07-20T13:09:35Z

@JohnTitor, oh, sorry, I've already got a fix. 🙂 I'll post it soon. Though it may not be the best one.

JohnTitor · 2020-07-20T13:14:31Z

@jakubadamw Great! You should tweak src/librustc_ast_lowering/pat.rs not losing diags. For further reference, you could do @rustbot claim when you work on an issue to avoid conflicts.

jakubadamw · 2020-07-20T13:26:33Z

@JohnTitor, okay, thanks. 🙂

Better late than never…

@rustbot claim

JohnTitor · 2020-07-20T13:35:31Z

This is caused by #72677, I believe. 1.44 emits errors w/o ICE'ing but 1.45 hits it.
godbolt (1.44): https://rust.godbolt.org/z/E1rbvz
godbolt (1.45): https://rust.godbolt.org/z/MGjPG4

JohnTitor · 2020-07-21T06:23:28Z

Let's keep this open to track stable/beta backports.

namibj · 2020-07-22T20:19:54Z

The reference suggested this to be possible, which is how I came to suggest it to OP.
We wanted to avoid naming them to not suggest any specific content.

Dylan-DPC-zz · 2020-07-23T23:01:41Z

here is another one: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=3f27a7faf85be38c646a6427b25b59c9 (assuming related)

Fix ICEs with `@ ..` binding This reverts rust-lang#74557 and introduces an alternative fix while ensuring that rust-lang#74954 is not broken. The diagnostics are verbose though, it fixes three related issues. cc rust-lang#74954, rust-lang#74539, and rust-lang#74702

JohnTitor · 2020-08-03T02:14:07Z

The stable fix is reverted, and the nightly one is also but #74963 introduced another fix. I keep this open when that PR is beta-nominated, just in case.

JohnTitor · 2020-08-04T22:05:21Z

We don't backport the fix in favor of this comment: #74557 (comment)
So I'm just going to close this as fixed.

r1fl added C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 19, 2020

jonas-schievink added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 19, 2020

JohnTitor self-assigned this Jul 20, 2020

JohnTitor removed their assignment Jul 20, 2020

jakubadamw mentioned this issue Jul 20, 2020

Fix an ICE on an invalid binding @ ... in a tuple struct pattern #74557

Merged

rustbot self-assigned this Jul 20, 2020

JohnTitor added the regression-from-stable-to-stable Performance or correctness regression from one stable version to another. label Jul 20, 2020

bors closed this as completed in 6bbf82d Jul 21, 2020

JohnTitor reopened this Jul 21, 2020

JohnTitor removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 21, 2020

LeSeulArtichaut mentioned this issue Jul 21, 2020

[stable] 1.45.1 release #74574

Merged

namibj mentioned this issue Jul 23, 2020

ICE with the (foo @ ..,) pattern #74702

Closed

JohnTitor mentioned this issue Jul 30, 2020

Fix ICEs with @ .. binding #74963

Merged

JohnTitor closed this as completed Aug 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ICE with the `@ ..` binding pattern #74539

ICE with the `@ ..` binding pattern #74539

r1fl commented Jul 19, 2020 •

edited by rustbot

Loading

matthiaskrgr commented Jul 20, 2020 •

edited

Loading

Uh oh!

jakubadamw commented Jul 20, 2020

Uh oh!

JohnTitor commented Jul 20, 2020 •

edited

Loading

Uh oh!

jakubadamw commented Jul 20, 2020

Uh oh!

JohnTitor commented Jul 20, 2020

Uh oh!

JohnTitor commented Jul 21, 2020

Uh oh!

namibj commented Jul 22, 2020

Uh oh!

Dylan-DPC-zz commented Jul 23, 2020

Uh oh!

JohnTitor commented Aug 3, 2020

Uh oh!

JohnTitor commented Aug 4, 2020

Uh oh!

ICE with the @ .. binding pattern #74539

ICE with the @ .. binding pattern #74539

Comments

r1fl commented Jul 19, 2020 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code

Meta

Error output

matthiaskrgr commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakubadamw commented Jul 20, 2020

Uh oh!

JohnTitor commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakubadamw commented Jul 20, 2020

Uh oh!

JohnTitor commented Jul 20, 2020

Uh oh!

JohnTitor commented Jul 21, 2020

Uh oh!

namibj commented Jul 22, 2020

Uh oh!

Dylan-DPC-zz commented Jul 23, 2020

Uh oh!

JohnTitor commented Aug 3, 2020

Uh oh!

JohnTitor commented Aug 4, 2020

Uh oh!

ICE with the `@ ..` binding pattern #74539

ICE with the `@ ..` binding pattern #74539

r1fl commented Jul 19, 2020 •

edited by rustbot

Loading

matthiaskrgr commented Jul 20, 2020 •

edited

Loading

JohnTitor commented Jul 20, 2020 •

edited

Loading