-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Use revisions to test min_const_generics
#75279
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Add a bunch of const-generic revisions for `min_const_generics` This adds a bunch of revisions to `const-generic` tests which is part of rust-lang#75279, but doesn't cover everything. r? @lcnr
I'll work on part of it |
…visions, r=lcnr Added some `min_const_generics` revisions into `const_generics` tests Help in rust-lang#75279. still a lot more to cover though r? @lcnr
Are all the tests done? Or is this being closed because of using the word "fixes" in #76514 ? |
because of the keyword "fixes". Don't think that all tests have been migrated yet |
I migrated all of the relevant tests I could find. I could go back and look. There are a few that simply didn't need revisions. Examples include things that test for the features being unstable and that I changed "partially addresses" to "fixes" only when I believed I'd gotten through all of them. |
I missed |
Uh oh!
There was an error while loading. Please reload this page.
cc #74878
#74877 implemented
feature(min_const_generics)
which is split off fromfeature(const_generics)
.As these two features have some meaningful differences it is desirable to run try and run all const generics tests with both features.
This can be done using
revisions
. Some tests were already updated in #74877:rust/src/test/ui/const-generics/issues/issue-56445.rs
Lines 1 to 13 in f9c2177
If you want to work on this feel free to ask for help here or on zulip.
The text was updated successfully, but these errors were encountered: