Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rename Option's swap_unwrap and friends to take_unwrap and friends. #7764

Closed
bblum opened this issue Jul 13, 2013 · 2 comments
Closed

Rename Option's swap_unwrap and friends to take_unwrap and friends. #7764

bblum opened this issue Jul 13, 2013 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bblum
Copy link
Contributor

bblum commented Jul 13, 2013

It is a better name. I was about to add fn swap(&mut self) -> Option<T> and realized it should really be named take. But it should be consistent with all the other ones, including also swap_map, which is not in master yet but will be soon...
@ozten ozten mentioned this issue Jul 16, 2013
Merged
bors added a commit that referenced this issue Jul 17, 2013
@bors
auto merge of #7831 : ozten/rust/issues-7764-swap_unwarp-take-unwrap,…
4bd716a 
… r=pcwalton

Fixes Issue #7764

Running `make check` I do get a failure:

    test rt::io::extensions::test::push_bytes ... ok
    rustest rt::comm::test::oneshot_single_thread_send_port_close ... t: task failed at 'Unhandled condition:
     read_error: {kind: OtherIoError, desc: "Placeholder error. You shouldn\'t be seeing this", detail: None}',
     /Users/shout/Projects/rust/src/libstd/condition.rs:50
    /bin/sh: line 1: 35056 Abort trap: 6           x86_64-apple-darwin/stage2/test/stdtest-x86_64-apple-darwin --logfile
     tmp/check-stage2-T-x86_64-apple-darwin-H-x86_64-apple-darwin-std.log
    make: *** [tmp/check-stage2-T-x86_64-apple-darwin-H-x86_64-apple-darwin-std.ok] Error 134
@bluss bluss mentioned this issue Jul 17, 2013
Closed
@Kimundi
Copy link
Member

Kimundi commented Jul 29, 2013

This can be closed now I think?

@bblum
Copy link
Contributor Author

bblum commented Jul 29, 2013

yep good work team

@bblum bblum closed this as completed Jul 29, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 21, 2021
@bors
Auto merge of rust-lang#7782 - dswij:shadow-unrelated-block, r=flip1995
872f321 
Make `shadow_reuse` suggestion less verbose

Closes rust-lang#7764

Make `shadow_reuse` suggestion less verbose.

changelog: [`shadow_reuse`] does not warn shadowing statement
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bblum @Kimundi