Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rust build system should be documented on the wiki. #7789

Closed
mstewartgallus opened this issue Jul 14, 2013 · 1 comment
Closed

Rust build system should be documented on the wiki. #7789

mstewartgallus opened this issue Jul 14, 2013 · 1 comment

Comments

@mstewartgallus
Copy link
Contributor

I feel it would make everybody much more productive if the build system was well documented. The need for people to know more about it is clearly shown by people posting stuff like this http://www.reddit.com/r/rust/comments/1fz5xu/public_service_announcement_make_checkstage1std/ .

All the details of the build system should be well documented including how to build, test, and benchmark Rust at all stages.
@brson
Copy link
Contributor

brson commented Jul 19, 2013

There are wiki pages for this:

https://github.com/mozilla/rust/wiki/Note-build-system
https://github.com/mozilla/rust/wiki/Note-testsuite

flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 21, 2021
@bors
Auto merge of rust-lang#7789 - flip1995:double_semi_if_nothing_return…
22144c0 
…ed, r=camsteffen

Don't trigger semicolon_if_nothing_returned in expanded code

Fixes rust-lang#7768

Before, this lint didn't trigger on macros. With rust-lang#88175
this isn't enough anymore. In this PR a `WhileLoop` desugaring kind was
introduced. This overrides the span of expanded expressions when
lowering the while loop. So if a while loop is in a macro, the
expressions that it expands to are no longer marked with
`ExpnKind::Macro`, but with `ExpnKind::Desugaring`. In general, this is
the correct behavior and the same that is done for `ForLoop`s. It just
tripped up this lint.

r? `@camsteffen`

changelog: [`semicolon_if_nothing_returned`]: Fix regression on macros containing while loops
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @mstewartgallus