-
Notifications
You must be signed in to change notification settings - Fork 13.4k
CTFE: remove memoization leftovers #79667
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
I want to work on this but i never contributed to rust-lang before so i need some guidance. |
Great! So... step 0 is to write The main change is to remove this function:
Ok(false) . This may allow some small cleanups at the call site; I expect nothing major to happen there.
I do not think there will be further test changes due to this, so, |
@rustbot claim |
Remove memoization leftovers from constant evaluation machine Closes rust-lang#79667
Remove memoization leftovers from constant evaluation machine Closes rust-lang#79667
Remove memoization leftovers from constant evaluation machine Closes rust-lang#79667
Remove memoization leftovers from constant evaluation machine Closes rust-lang#79667
Remove memoization leftovers from constant evaluation machine Closes rust-lang#79667
Remove memoization leftovers from constant evaluation machine Closes rust-lang#79667
Remove memoization leftovers from constant evaluation machine Closes rust-lang#79667
Uh oh!
There was an error while loading. Please reload this page.
Since #79594, memoization of argumentless functions is restricted to intrinsics, because other functions could perform heap allocations and thus memoization would be incorrect.
I doubt we have any argumentless intrinsic that is expensive enough that memoization is worth it, so I propose we remove the leftovers of that infrastructure.
Cc @rust-lang/wg-const-eval
The text was updated successfully, but these errors were encountered: