-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Optimization for bool's PartialOrd impl #80034
Labels
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
By the way, you don't need to open an issue if you're about to open a PR. Just include what you would put in the issue in the PR! |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Dec 15, 2020
Optimization for bool's PartialOrd impl Fix rust-lang#80034.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Dec 15, 2020
Optimization for bool's PartialOrd impl Fix rust-lang#80034.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Dec 15, 2020
Optimization for bool's PartialOrd impl Fix rust-lang#80034.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Dec 16, 2020
Optimization for bool's PartialOrd impl Fix rust-lang#80034.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Dec 16, 2020
Optimization for bool's PartialOrd impl Fix rust-lang#80034.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Dec 16, 2020
Optimization for bool's PartialOrd impl Fix rust-lang#80034.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
#66780 suggested an optimization for
impl Ord for bool
, and it was implemented in #66881.However, for some reason,
impl PartialOrd for bool
was not optimized the same way:rust/library/core/src/cmp.rs
Lines 1286 to 1300 in 1f7762b
rust/library/core/src/cmp.rs
Lines 1236 to 1241 in 1f7762b
It can be implemented in terms of
Ord
:Is this deliberate or just something that no-one noticed?
The text was updated successfully, but these errors were encountered: