Skip to content

rls no longer builds after rust-lang/rust#79576 #80576

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
rust-highfive opened this issue Jan 1, 2021 · 1 comment · Fixed by #81027
Closed

rls no longer builds after rust-lang/rust#79576 #80576

rust-highfive opened this issue Jan 1, 2021 · 1 comment · Fixed by #81027
Assignees
@Xanewok
Labels
C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #79576, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @m-ou-se, do you think you would have time to do the follow-up work?
If so, that would be great!
@rust-highfive rust-highfive added A-rls C-bug Category: This is a bug. labels Jan 1, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Jan 1, 2021

A complete fix is blocked on rustfmt knowing about edition 2021 too. And that is blocked on rustc-ap-rustc_span on crates.io to update to a version that includes edition 2021.

To fix the build for now, rls could temporarily pass Edition2018 to rustfmt for 2021.

@m-ou-se m-ou-se mentioned this issue Jan 1, 2021
Merged
@calebcartwright calebcartwright mentioned this issue Jan 1, 2021
Merged
bors added a commit to rust-lang/rls that referenced this issue Jan 10, 2021
@bors
Auto merge of #1709 - m-ou-se:2021, r=Xanewok
288260a 
Add edition 2021.

See rust-lang/rust#80576. This un-breaks the build of RLS after rust-lang/rust#79576 broke it.
@Xanewok Xanewok mentioned this issue Jan 15, 2021
Merged
@bors bors closed this as completed in 3419da8 Jan 15, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Xanewok Xanewok

Labels
C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RLS and Rustfmt Xanewok/rust
3 participants
@m-ou-se @Xanewok @rust-highfive