Skip to content

clang-sys 0.29.3 fails to build on nightly #84162

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Nemo157 opened this issue Apr 13, 2021 · 5 comments · Fixed by #84130
Closed

clang-sys 0.29.3 fails to build on nightly #84162

Nemo157 opened this issue Apr 13, 2021 · 5 comments · Fixed by #84130
Labels
C-bug Category: This is a bug. P-critical Critical priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@Nemo157
Copy link
Member

Nemo157 commented Apr 13, 2021

I tried building clang-sys 0.29.3 with feature runtime on the latest nightly.

I expected to see this happen: it builds successfully.

Instead, this happened:

> cargo +nightly build --features runtime |& head -n 20
   Compiling clang-sys v0.29.3 (/tmp/tmp.EH8ss9nTlb/clang-sys-0.29.3)
error[E0642]: patterns aren't allowed in methods without bodies
    --> src/lib.rs:1660:39
     |
1660 |     pub fn clang_CXCursorSet_contains(set: CXCursorSet, cursor: CXCursor) -> c_uint;
     |                                       ^^^
     |
help: give this argument a name or use an underscore to ignore it
     |
1660 |     pub fn clang_CXCursorSet_contains(_: CXCursorSet, cursor: CXCursor) -> c_uint;
     |                                       ^

error[E0642]: patterns aren't allowed in methods without bodies
    --> src/lib.rs:1660:57
     |
1660 |     pub fn clang_CXCursorSet_contains(set: CXCursorSet, cursor: CXCursor) -> c_uint;
     |                                                         ^^^^^^
     |
help: give this argument a name or use an underscore to ignore it
     |

Meta[

rustc --version --verbose:

rustc 1.53.0-nightly (d0695c908 2021-04-12)
binary: rustc
commit-hash: d0695c9081b16077d0aed368bccaf437d77ff497
commit-date: 2021-04-12
host: x86_64-unknown-linux-gnu
release: 1.53.0-nightly
LLVM version: 12.0.0
@Nemo157 Nemo157 added the C-bug Category: This is a bug. label Apr 13, 2021
@jyn514 jyn514 added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Apr 13, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Apr 13, 2021
@jyn514 jyn514 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 13, 2021
@Nemo157
Copy link
Member Author

Nemo157 commented Apr 13, 2021

First regressed in rustc 1.53.0-nightly (a86612456 2021-04-11).

@Aaron1011
Copy link
Member

Will be fixed by #84130

unageek added a commit to unageek/graphest that referenced this issue Apr 14, 2021
unageek added a commit to unageek/graphest that referenced this issue Apr 14, 2021
* Fix derivation and implementation of GCD

* Workaround for rust-lang/rust#84162

* 💄
@SimonSapin
Copy link
Contributor

This affects Servo too, through rust-bindgen:

searched nightlies: from nightly-2021-04-10 to nightly-2021-04-12
regressed nightly: nightly-2021-04-12
searched commits: from a836d9b to a866124
regressed commit: ba6275b

bisected with cargo-bisect-rustc v0.6.0

Host triple: x86_64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc -- check --features runtime 

@apiraino
Copy link
Contributor

Assigning P-critical for its impact, as discussed as part of the Prioritization Working Group procedure and removing I-prioritize.

@rustbot label -I-prioritize +P-critical

@rustbot rustbot added P-critical Critical priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Apr 14, 2021
@pnkfelix
Copy link
Member

For the record, according to the bisection performed by @SimonSapin above, this was injected by PR #82608. (But as @Aaron1011 noted above, it will be fixed by PR #84130.)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-bug Category: This is a bug. P-critical Critical priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants