Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

rustdoc doesn't include renamed re-exports in search results #86337

Closed
jyn514 opened this issue Jun 15, 2021 · 1 comment · Fixed by #103758
Closed

rustdoc doesn't include renamed re-exports in search results #86337

jyn514 opened this issue Jun 15, 2021 · 1 comment · Fixed by #103758
Labels
A-rustdoc-search Area: Rustdoc's search feature C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Jun 15, 2021

I tried this: Go to https://docs.rs/tracing-subscriber/0.2.18/tracing_subscriber/ and search for FmtSubscriber

I expected to see this happen: Rustdoc shows a search result for https://docs.rs/tracing-subscriber/0.2.18/tracing_subscriber/fmt/struct.Subscriber.html, which is re-exported as FmtSubscriber in the root.

Instead, this happened: Rustdoc doesn't show any results.

Meta

This was generated with rustdoc 1.53.0-nightly (42816d61e 2021-04-24)
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-rustdoc-search Area: Rustdoc's search feature labels Jun 15, 2021
@euclio euclio mentioned this issue Dec 9, 2021
Closed
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Oct 30, 2022 •
edited
Loading

Seems like this issue was fixed:

Screenshot from 2022-10-30 13-41-57

I'll add a regression test to enforce this behaviour to close this issue.

@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 30, 2022
Merged
notriddle added a commit to notriddle/rust that referenced this issue Oct 30, 2022
@notriddle
Rollup merge of rust-lang#103758 - GuillaumeGomez:reexports-search-re…
7080630 
…sult-test, r=notriddle

Add regression test for reexports in search results

Fixes rust-lang#86337.

r? `@notriddle`
@bors bors closed this as completed in 4473fcd Oct 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-rustdoc-search Area: Rustdoc's search feature C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add regression test for reexports in search results GuillaumeGomez/rust
2 participants
@GuillaumeGomez @jyn514