-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Doublicated ld\ld64 executables added into rustc package, increasing it's size #88869
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
P-medium
Medium priority
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
Milestone
Comments
Can be found in:
|
Assigning priority as discussed in the Zulip thread of the Prioritization Working Group. @rustbot label -I-prioritize +P-medium |
@rustbot claim |
Sorry, I only came across this issue just now. The copies are there for a reason, see linked issues. Multiple things to consider:
|
This was referenced Sep 24, 2021
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Oct 5, 2021
…ulacrum Wrapper for `-Z gcc-ld=lld` to invoke rust-lld with the correct flavor This PR adds an `lld-wrapper` tool which is installed as `ld` and `ld64` in `lib\rustlib\<host_target>\bin\gcc-ld` directory and whose sole purpose is to invoke `rust-lld` in the parent directory with the correct flavor. Lld decides which flavor to use from either the first two commandline arguments or from the name of the executable (`ld` for GNU/ld flavor, `ld64` for Darwin/Macos/ld64 flavor and so on). Symbolic links could not be used as they are not supported by rustup and on Windows. The wrapper replaces full copies of rust-lld which added some significant bloat. On UNIXish operating systems it exec rust-lld, on Windows it spawns it as a child process. Fixes rust-lang#88869. r? `@Mark-Simulacrum` cc `@nagisa` `@petrochenkov` `@1000teslas`
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Oct 7, 2021
…ulacrum Wrapper for `-Z gcc-ld=lld` to invoke rust-lld with the correct flavor This PR adds an `lld-wrapper` tool which is installed as `ld` and `ld64` in `lib\rustlib\<host_target>\bin\gcc-ld` directory and whose sole purpose is to invoke `rust-lld` in the parent directory with the correct flavor. Lld decides which flavor to use from either the first two commandline arguments or from the name of the executable (`ld` for GNU/ld flavor, `ld64` for Darwin/Macos/ld64 flavor and so on). Symbolic links could not be used as they are not supported by rustup and on Windows. The wrapper replaces full copies of rust-lld which added some significant bloat. On UNIXish operating systems it exec rust-lld, on Windows it spawns it as a child process. Fixes rust-lang#88869. r? `@Mark-Simulacrum` cc `@nagisa` `@petrochenkov` `@1000teslas`
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Oct 8, 2021
…ulacrum Wrapper for `-Z gcc-ld=lld` to invoke rust-lld with the correct flavor This PR adds an `lld-wrapper` tool which is installed as `ld` and `ld64` in `lib\rustlib\<host_target>\bin\gcc-ld` directory and whose sole purpose is to invoke `rust-lld` in the parent directory with the correct flavor. Lld decides which flavor to use from either the first two commandline arguments or from the name of the executable (`ld` for GNU/ld flavor, `ld64` for Darwin/Macos/ld64 flavor and so on). Symbolic links could not be used as they are not supported by rustup and on Windows. The wrapper replaces full copies of rust-lld which added some significant bloat. On UNIXish operating systems it exec rust-lld, on Windows it spawns it as a child process. Fixes rust-lang#88869. r? ``@Mark-Simulacrum`` cc ``@nagisa`` ``@petrochenkov`` ``@1000teslas``
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
P-medium
Medium priority
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
Uh oh!
There was an error while loading. Please reload this page.
Checked that on
x86_64-pc-windows-msvc
target,found duplicates in versions:
and
no duplicates2 duplicates (onlyrust-lld.exe
,ld.exe
) in stablerustc 1.55.0 (c8dfcfe04 2021-09-06)
,rustc 1.56.0-nightly (4e282795d 2021-07-31)
(bisecting is kinda slow on my connection)
there 3 copies of that executable, that gives ~ 187mb
@rustbot label +regression-from-stable-to-beta
The text was updated successfully, but these errors were encountered: