Skip to content

io::ErrorKind should suggest c&p current list of kinds into test cases #89175

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
ijackson opened this issue Sep 22, 2021 · 1 comment
Open

io::ErrorKind should suggest c&p current list of kinds into test cases #89175

ijackson opened this issue Sep 22, 2021 · 1 comment
Labels
A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ijackson
Copy link
Contributor

The introduction of the perma-usntable Uncategorized is IMO correct, but it is causing quite a lot of trouble for people (see comments in #86442 for example). One difficulty is that people experiencing breakage aren't given clear guidance on how to fix their code, which is a poor UX.

As I wrote in #79965 (comment) I think the right answer in some cases (eg for a thorough test case) is to cut and paste the list of currently-stable kinds from the stdlib docs into one's codbase. This is counterintuitive but IMO correct.

I think it would be useful to recommend this somewhere in the docs for io::ErrorKind. If the community agrees I will send an MR. But I thought I would test the waters with this issue, first.
@ijackson
Copy link
Contributor Author

@rustbot modify labels +T-libs-api +A-io

@rustbot rustbot added A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 22, 2021
ijackson added a commit to ijackson/rust that referenced this issue Nov 8, 2021
@ijackson
io::ErrorKind: Discuss matching
ae64da2 
Closes rust-lang#89175

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
@ijackson ijackson mentioned this issue Nov 8, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

io::ErrorKind: Discuss matching ijackson/rust
2 participants
@ijackson @rustbot