rustdoc: Compute visibility on-demand, using ty::Visibility
#90852
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
E-medium
Call for participation: Medium difficulty. Experience needed to fix: Intermediate.
I-compilemem
Issue: Problems and improvements with respect to memory usage during compilation.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
camelid
added
C-cleanup
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Nov 2, 2022
… r=notriddle Make rustdoc Item::visibility computed on-demand This is a take-over of rust-lang#91408. Helps with rust-lang#90852 (needs to use `ty::Visibility` directly too). cc `@camelid` r? `@notriddle`
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this issue
Nov 5, 2022
Make rustdoc Item::visibility computed on-demand This is a take-over of rust-lang/rust#91408. Helps with rust-lang/rust#90852 (needs to use `ty::Visibility` directly too). cc `@camelid` r? `@notriddle`
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this issue
Apr 20, 2024
Make rustdoc Item::visibility computed on-demand This is a take-over of rust-lang/rust#91408. Helps with rust-lang/rust#90852 (needs to use `ty::Visibility` directly too). cc `@camelid` r? `@notriddle`
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this issue
Apr 27, 2024
Make rustdoc Item::visibility computed on-demand This is a take-over of rust-lang/rust#91408. Helps with rust-lang/rust#90852 (needs to use `ty::Visibility` directly too). cc `@camelid` r? `@notriddle`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Currently, rustdoc computes visibility ahead of time and stores it in
Item.visibility. rustdoc also has its own visibility representation:clean::Visibility.Instead, rustdoc should just use
ty::Visibilitydirectly, and compute it on-demand using anItem::visibility()function.The text was updated successfully, but these errors were encountered: