Skip to content

regression: Display and Debug for ErrorKind #94507

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Mark-Simulacrum opened this issue Mar 1, 2022 · 3 comments
Closed

regression: Display and Debug for ErrorKind #94507

Mark-Simulacrum opened this issue Mar 1, 2022 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

Crater picked up this issue in a number of crates:

[INFO] [stdout] error[E0034]: multiple applicable items in scope
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/github.heygears.com-1ecc6299db9ec823/lightning-0.0.104/src/ln/msgs.rs:962:32
[INFO] [stdout]     |
[INFO] [stdout] 962 |             DecodeError::Io(ref e) => e.fmt(f),
[INFO] [stdout]     |                                         ^^^ multiple `fmt` found
[INFO] [stdout]     |
[INFO] [stdout]     = note: candidate #1 is defined in an impl of the trait `std::fmt::Display` for the type `ErrorKind`
[INFO] [stdout]     = note: candidate #2 is defined in an impl of the trait `Debug` for the type `ErrorKind`
[INFO] [stdout] help: disambiguate the associated function for candidate #1
[INFO] [stdout]     |
[INFO] [stdout] 962 |             DecodeError::Io(ref e) => std::fmt::Display::fmt(&e, f),
[INFO] [stdout]     |                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[INFO] [stdout] help: disambiguate the associated function for candidate #2
[INFO] [stdout]     |
[INFO] [stdout] 962 |             DecodeError::Io(ref e) => Debug::fmt(&e, f),
[INFO] [stdout]     |                                       ~~~~~~~~~~~~~~~~~
[INFO] [stdout] 
@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels Mar 1, 2022
@Mark-Simulacrum Mark-Simulacrum added this to the 1.60.0 milestone Mar 1, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Mar 1, 2022
@ehuss
Copy link
Contributor

ehuss commented Mar 2, 2022

This is more discussion of this in #93599.

@yaahc
Copy link
Member

yaahc commented Mar 2, 2022

caused by #93090

@m-ou-se
Copy link
Member

m-ou-se commented Mar 2, 2022

Discussed in the libs meeting just now. We consider this breakage acceptable.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

7 participants