Skip to content

prevent adding more binaries #9621

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
thestinger opened this issue Sep 30, 2013 · 3 comments · Fixed by #9628
Closed

prevent adding more binaries #9621

thestinger opened this issue Sep 30, 2013 · 3 comments · Fixed by #9628

Comments

@thestinger
Copy link
Contributor

We keep adding test/library binaries to the history, and it's already quite large. It should just be prevented on the build bots, excluding ones intentionally added to a list of exceptions.

It's too late to remove the old ones from the history, but not too late to avoid adding more 10MiB binaries everyone has to clone.

@alexcrichton
Copy link
Member

Oh dear, sorry about that!

I think I've done this more than once, and I'd love to have a way to prevent this. I know we can't install hooks by default, but it would also be nice to have a hook script with instructions of how to use it somewhere in perhaps src/etc.

@huonw
Copy link
Member

huonw commented Sep 30, 2013

We can add hooks to the buildbot/build scripts themselves though? (e.g. put something in tidy that checks for checked-in-binaries.)

@alexcrichton
Copy link
Member

Now that you mention it, I think that tidy would be an excellent location for this.

flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 23, 2022
fix `box-default` ignoring trait objects' types

This avoids removing the turbofish when the `Box` type is a `dyn` or `impl _`.

This fixes rust-lang#9621.

---

changelog: none
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants