Skip to content

Allow -A, -W and -D in x.py clippy arguments #97059

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Milo123459 opened this issue May 15, 2022 · 2 comments · Fixed by #97210
Closed

Allow -A, -W and -D in x.py clippy arguments #97059

Milo123459 opened this issue May 15, 2022 · 2 comments · Fixed by #97210
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Milo123459
Copy link
Contributor

Currently, you cannot pass those CLI flags to x.py clippy. It would be useful if this was possible.
@matthiaskrgr
Copy link
Member

you can add them to the args vec in src/bootstrap/check.rs:46, that will work temporarily

@Milo123459
Copy link
Contributor Author

Ah, thanks for letting me know. I still think that allowing support for these flags is a good idea though.

@JohnTitor JohnTitor added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 16, 2022
@Milo123459 Milo123459 mentioned this issue May 20, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#97210 - Milo123459:clippy-args, r=jyn514
f6f6187 
Support `-A`, `-W`, `-D` and `-F` when running `./x.py clippy`

Resolves rust-lang#97059

This PR adds support for `-A`, `-W`, `-D` and `-F` when running `./x.py clippy`.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#97210 - Milo123459:clippy-args, r=jyn514
dc2f129 
Support `-A`, `-W`, `-D` and `-F` when running `./x.py clippy`

Resolves rust-lang#97059

This PR adds support for `-A`, `-W`, `-D` and `-F` when running `./x.py clippy`.
@bors bors closed this as completed in 601c5a2 Jul 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support -A, -W, -D and -F when running ./x.py clippy
3 participants
@matthiaskrgr @JohnTitor @Milo123459