-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Codegen/allocator regression from 1.60 #97217
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
A-codegen
Area: Code generation
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
C-bug
Category: This is a bug.
P-medium
Medium priority
regression-from-stable-to-stable
Performance or correctness regression from one stable version to another.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
This comment was marked as outdated.
This comment was marked as outdated.
The allocation also goes away with opt-level 3 if you pass |
WG-prioritization assigning priority (Zulip discussion). @rustbot label -I-prioritize +P-high |
T-compiler P-high review, adding T-compiler label. @rustbot label +T-compiler +A-LLVM |
T-compiler P-high review, downgrading to P-medium. @rustbot label: -P-high +P-medium |
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this issue
Jun 27, 2023
…=nikic Rebased: Mark drop calls in landing pads cold instead of noinline I noticed that certain inlining optimizations were missing while staring at some compiled code output. I'd like to see this relanded, so I rebased the PR from ``@erikdesjardins`` (PR rust-lang#94823). This PR reapplies rust-lang#92419, which was reverted in rust-lang#94402 due to rust-lang#94390. Fixes rust-lang#46515, fixes rust-lang#87055. Update: fixes rust-lang#97217.
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Oct 2, 2023
…ikic Rebased: Mark drop calls in landing pads cold instead of noinline I noticed that certain inlining optimizations were missing while staring at some compiled code output. I'd like to see this relanded, so I rebased the PR from `@erikdesjardins` (PR rust-lang#94823). This PR reapplies rust-lang#92419, which was reverted in rust-lang#94402 due to rust-lang#94390. Fixes rust-lang#46515, fixes rust-lang#87055. Update: fixes rust-lang#97217.
antoyo
pushed a commit
to antoyo/rust
that referenced
this issue
Oct 9, 2023
…ikic Rebased: Mark drop calls in landing pads cold instead of noinline I noticed that certain inlining optimizations were missing while staring at some compiled code output. I'd like to see this relanded, so I rebased the PR from `@erikdesjardins` (PR rust-lang#94823). This PR reapplies rust-lang#92419, which was reverted in rust-lang#94402 due to rust-lang#94390. Fixes rust-lang#46515, fixes rust-lang#87055. Update: fixes rust-lang#97217.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
A-codegen
Area: Code generation
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
C-bug
Category: This is a bug.
P-medium
Medium priority
regression-from-stable-to-stable
Performance or correctness regression from one stable version to another.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
In 1.60 the following code causes no allocations:
However in nightly there is an allocation, see: https://godbolt.org/z/cq9b1Pnva
EDIT:
Appears there is also a problem with 1.60 and opt-level 2 vs 3: https://godbolt.org/z/8MWjEvPbh
The text was updated successfully, but these errors were encountered: