-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Using try operator on a future doesn't suggest to .await it #97704
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Huh, looks like this is a case where |
Ah, it's that the |
It doesn't seem like the problem that caused #72766 is a thing anymore? I can remove the |
@JohnTitor do you know if stuff has changed such that #72775 is no longer necessary? |
@coolreader18 I actually have a PR almost up that does just exactly that, though if you want to put one up instead then feel free. |
I'm pretty sure #86901 fixes this underlying issue. This method could use some additional cleanup as well. |
…h726 Do `suggest_await_before_try` with infer variables in self, and clean up binders Fixes rust-lang#97704 Also cleans up binders in this fn, since everything is a `Poly*` and we really shouldn't have stray escaping late-bound regions everywhere. That's why the function changed so much. This isn't necessary, so I can revert if necessary.
…li-obk Add proper tracing spans to rustc_trait_selection::traits::error_reporting While I was trying to figure out rust-lang#97704 I did some of this to make the logs more legible, so I figured I'd do the whole module and open a PR with it. afaict this is an ongoing process in the compiler from the log->tracing transition? but lmk if there was a reason for the more verbose forms of logging as they are. Also, for some of the functions with only one log in them, I put the function name as a message for that log instead of `#[instrument]`-ing the whole function with a span? but maybe the latter would actually be preferable, I'm not actually sure.
Given the following code: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=b539ebe10f181c1f2b245a021684dff1
The current output is:
Ideally the output should look like:
The text was updated successfully, but these errors were encountered: