Skip to content

miri no longer builds after rust-lang/rust#98486 #98493

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
rust-highfive opened this issue Jun 25, 2022 · 1 comment · Fixed by #98518
Closed

miri no longer builds after rust-lang/rust#98486 #98493

rust-highfive opened this issue Jun 25, 2022 · 1 comment · Fixed by #98518
Assignees
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #98486, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @matthiaskrgr, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Jun 25, 2022
bors added a commit to rust-lang/miri that referenced this issue Jun 25, 2022
rustup

I cannot reproduce rust-lang/rust#98493 so let's see what CI says.
@RalfJung
Copy link
Member

command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "--edition" "2018" "-Astable-features" "--sysroot" "/home/user/.cache/miri/HOST" "-Zui-testing" "tests/pass/concurrency/sync.rs" "--error-format=json" "-Zmiri-disable-isolation" "-Zmiri-strict-provenance"
Pass got exit status: 1
actual output differed from expected tests/pass/concurrency/sync.stderr
Diff< left / right > :
>error: the main thread terminated without waiting for all remaining threads
>
>note: pass `-Zmiri-ignore-leaks` to disable this check
>
>error: aborting due to previous error

Probably a missing join (these tests are a bit random, now that we have preemption).

bors added a commit to rust-lang/miri that referenced this issue Jun 25, 2022
rustup

I cannot reproduce rust-lang/rust#98493 so let's see what CI says.
bors added a commit to rust-lang/miri that referenced this issue Jun 25, 2022
rustup

I cannot reproduce rust-lang/rust#98493 so let's see what CI says.
bors added a commit to rust-lang/miri that referenced this issue Jun 25, 2022
rustup

I cannot reproduce rust-lang/rust#98493 so let's see what CI says.
bors added a commit to rust-lang/miri that referenced this issue Jun 25, 2022
rustup

I cannot reproduce rust-lang/rust#98493 so let's see what CI says.
bors added a commit to rust-lang/miri that referenced this issue Jun 25, 2022
rustup

I cannot reproduce rust-lang/rust#98493 so let's see what CI says.
@RalfJung RalfJung mentioned this issue Jun 26, 2022
@bors bors closed this as completed in 7125846 Jun 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants