change rlib format to distinguish native dependencies #100101

belovdv · 2022-08-03T08:21:35Z

Another one method to solve problem mentioned in #99429.

Changed .rlib format, it contains all bundled native libraries as archieves.
At link time rlib is unpacked and native dependencies linked separately.
New behavior hidden under separate_native_rlib_dependencies flag.

rust-highfive · 2022-08-03T08:21:38Z

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

rustbot · 2022-08-03T08:41:00Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

petrochenkov · 2022-08-03T08:46:20Z

r? @petrochenkov

belovdv · 2022-08-04T10:53:27Z

@rustbot ready

compiler/rustc_session/src/options.rs

compiler/rustc_codegen_ssa/src/back/link.rs

compiler/rustc_codegen_ssa/src/back/archive.rs

compiler/rustc_codegen_ssa/src/back/link.rs

compiler/rustc_session/src/options.rs

compiler/rustc_codegen_ssa/src/back/archive.rs

compiler/rustc_codegen_ssa/src/back/link.rs

compiler/rustc_codegen_ssa/src/back/archive.rs

rustbot · 2022-09-12T10:23:09Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

belovdv · 2022-09-12T12:50:20Z

@rustbot ready

petrochenkov · 2022-09-12T13:47:36Z

@bors r+

bors · 2022-09-12T13:47:39Z

📌 Commit ffa8359 has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2022-09-12T13:47:40Z

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

bors · 2022-09-13T04:00:28Z

⌛ Testing commit ffa8359 with merge 9da4644...

bors · 2022-09-13T06:41:30Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 9da4644 to master...

rust-timer · 2022-09-13T07:58:05Z

Finished benchmarking commit (9da4644): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-2.5%	[-3.5%, -1.4%]	2
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

…-mingw-import-libraries, r=petrochenkov linker: Allow MSVC to use import libraries following the Meson/MinGW convention Hi all, This PR implements support for `MsvcLinker` to use import libraries following Meson and the MinGW toolchain's naming convention. Meson [follows the `libfoo.dll.a` naming convention](https://mesonbuild.com/FAQ.html#why-does-building-my-project-with-msvc-output-static-libraries-called-libfooa) to disambiguate between static and import libraries. This support already existed for static libraries (see rust-lang#100101), but not for dynamic libraries. The latter case was added by duplicating the logic in `native_libs::find_native_static_library`, but a separate case was added in `link_dylib_by_name` for the Windows CRT libraries which must be handled by the linker itself. See for prerequisites rust-lang#129366, rust-lang#126094, and rust-lang#128370. All feedback is appreciated! Fixes rust-lang#122455 cc `@sdroege` `@nirbheek`

…nd-mingw-import-libraries, r=petrochenkov linker: Allow MSVC to use import libraries following the Meson/MinGW convention Hi all, This PR implements support for `MsvcLinker` to use import libraries following Meson and the MinGW toolchain's naming convention. Meson [follows the `libfoo.dll.a` naming convention](https://mesonbuild.com/FAQ.html#why-does-building-my-project-with-msvc-output-static-libraries-called-libfooa) to disambiguate between static and import libraries. This support already existed for static libraries (see rust-lang#100101), but not for dynamic libraries. The latter case was added by duplicating the logic in `native_libs::find_native_static_library`, but a separate case was added in `link_dylib_by_name` for the Windows CRT libraries which must be handled by the linker itself. See for prerequisites rust-lang#129366, rust-lang#126094, and rust-lang#128370. All feedback is appreciated! Fixes rust-lang#122455 cc `@sdroege` `@nirbheek`

Rollup merge of rust-lang#123436 - amyspark:allow-msvc-to-use-meson-and-mingw-import-libraries, r=petrochenkov linker: Allow MSVC to use import libraries following the Meson/MinGW convention Hi all, This PR implements support for `MsvcLinker` to use import libraries following Meson and the MinGW toolchain's naming convention. Meson [follows the `libfoo.dll.a` naming convention](https://mesonbuild.com/FAQ.html#why-does-building-my-project-with-msvc-output-static-libraries-called-libfooa) to disambiguate between static and import libraries. This support already existed for static libraries (see rust-lang#100101), but not for dynamic libraries. The latter case was added by duplicating the logic in `native_libs::find_native_static_library`, but a separate case was added in `link_dylib_by_name` for the Windows CRT libraries which must be handled by the linker itself. See for prerequisites rust-lang#129366, rust-lang#126094, and rust-lang#128370. All feedback is appreciated! Fixes rust-lang#122455 cc `@sdroege` `@nirbheek`

rust-highfive assigned davidtwco Aug 3, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 3, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2022

This comment has been minimized.

# to view

rust-highfive assigned petrochenkov and unassigned davidtwco Aug 3, 2022

belovdv force-pushed the issue-99429 branch from 88c61de to 9abd63a Compare August 3, 2022 08:50

This comment has been minimized.

# to view

belovdv force-pushed the issue-99429 branch from 305a680 to 19f156e Compare August 4, 2022 07:27

This comment has been minimized.

# to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2022

petrochenkov reviewed Aug 4, 2022

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2022

bjorn3 reviewed Aug 4, 2022

View reviewed changes

compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Aug 5, 2022

View reviewed changes

compiler/rustc_codegen_ssa/src/back/archive.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Aug 5, 2022

View reviewed changes

compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved

petrochenkov reviewed Aug 5, 2022

View reviewed changes

bjorn3 reviewed Aug 6, 2022

View reviewed changes

compiler/rustc_codegen_ssa/src/back/archive.rs Outdated Show resolved Hide resolved

belovdv force-pushed the issue-99429 branch 2 times, most recently from 44e35fd to a60525e Compare August 7, 2022 12:05

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 2, 2022

This comment was marked as resolved.

# to view

belovdv force-pushed the issue-99429 branch from 5bf9c7b to 7ff3c39 Compare September 12, 2022 10:23

rustbot added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Sep 12, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 12, 2022

change rlib format to discern native dependencies

ffa8359

belovdv force-pushed the issue-99429 branch from 7ff3c39 to ffa8359 Compare September 12, 2022 13:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 13, 2022

bors merged commit 9da4644 into rust-lang:master Sep 13, 2022

rustbot added this to the 1.65.0 milestone Sep 13, 2022

This was referenced Sep 13, 2022

Rewrite LLVM's archive writer in Rust #97485

Merged

Move and rename SessionDiagnostic & SessionSubdiagnostic traits and macros #101558

Merged

ehuss mentioned this pull request Oct 14, 2022

rlib-format-packed-bundled-libs test failures on Xcode 14 #103044

Closed

matthiaskrgr mentioned this pull request Oct 30, 2023

ICE: failure to relate an opaque to itself should result in an error later on #117392

Open

amyspark mentioned this pull request Sep 14, 2024

linker: Allow MSVC to use import libraries following the Meson/MinGW convention #123436

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change rlib format to distinguish native dependencies #100101

change rlib format to distinguish native dependencies #100101

belovdv commented Aug 3, 2022

rust-highfive commented Aug 3, 2022

This comment has been minimized.

rustbot commented Aug 3, 2022

petrochenkov commented Aug 3, 2022

This comment has been minimized.

This comment has been minimized.

belovdv commented Aug 4, 2022

This comment was marked as resolved.

rustbot commented Sep 12, 2022

belovdv commented Sep 12, 2022

petrochenkov commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 13, 2022

bors commented Sep 13, 2022

rust-timer commented Sep 13, 2022

change rlib format to distinguish native dependencies #100101

change rlib format to distinguish native dependencies #100101

Conversation

belovdv commented Aug 3, 2022

rust-highfive commented Aug 3, 2022

This comment has been minimized.

rustbot commented Aug 3, 2022

petrochenkov commented Aug 3, 2022

This comment has been minimized.

This comment has been minimized.

belovdv commented Aug 4, 2022

This comment was marked as resolved.

rustbot commented Sep 12, 2022

belovdv commented Sep 12, 2022

petrochenkov commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 13, 2022

bors commented Sep 13, 2022

rust-timer commented Sep 13, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes