triagebot: add translation-related mention groups #100379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
T-compiler
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
rust-highfive
added
the
S-waiting-on-review
davidtwco
commented
Aug 10, 2022
triagebot.toml
Outdated
|
|
||
| [mentions."compiler/rustc_macros/src/diagnostics"] | ||
| message = "`rustc_macros::diagnostics` was changed" | ||
| cc = ["@davidtwco"] |
There was a problem hiding this comment.
@rust-lang/wg-diagnostics anyone else want in these groups?
There was a problem hiding this comment.
Could you also add me? Thanks!
|
r=me, but will let you approve after folks chime in |
This comment has been minimized.
This comment has been minimized.
davidtwco
force-pushed
the
triagebot-diag
branch
from
5e57413 to
16f6b39
Compare
Mark-Simulacrum
added
S-waiting-on-author
|
Can we get triagebot to auto-label PRs with:
A-translation
|
davidtwco
force-pushed
the
triagebot-diag
branch
from
16f6b39 to
610ffe5
Compare
Added! |
This comment was marked as resolved.
This comment was marked as resolved.
Just moving code around so that triagebot can ping relevant parties when translation logic is modified. Signed-off-by: David Wood <david.wood@huawei.com>
Add mention groups to `triagebot.toml` for diagnostic derive macros and diagnostic translation sources/resources. Signed-off-by: David Wood <david.wood@huawei.com>
davidtwco
force-pushed
the
triagebot-diag
branch
from
610ffe5 to
a5d8864
Compare
Instruct triagebot to autolabel pull requests that modify the translation sources with the `A-translation` label. Signed-off-by: David Wood <david.wood@huawei.com>
davidtwco
force-pushed
the
triagebot-diag
branch
from
a5d8864 to
ae02014
Compare
|
@bors r=Mark-Simulacrum rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 17, 2022
…iaskrgr Rollup of 15 pull requests Successful merges: - rust-lang#99474 (Rustdoc json tests: New `@hasexact` test command) - rust-lang#99972 (interpret: only consider 1-ZST when searching for receiver) - rust-lang#100018 (Clean up `LitKind`) - rust-lang#100379 (triagebot: add translation-related mention groups) - rust-lang#100389 (Do not report cycle error when inferring return type for suggestion) - rust-lang#100489 (`is_knowable` use `Result` instead of `Option`) - rust-lang#100532 (unwind: don't build dependency when building for Miri) - rust-lang#100608 (needless separation of impl blocks) - rust-lang#100621 (Pass +atomics-32 feature for {arm,thumb}v4t-none-eabi) - rust-lang#100646 (Migrate emoji identifier diagnostics to `SessionDiagnostic` in rustc_interface) - rust-lang#100652 (Remove deferred sized checks (make them eager)) - rust-lang#100655 (Update books) - rust-lang#100656 (Update cargo) - rust-lang#100660 (Fixed a few documentation errors) - rust-lang#100661 (Fixed a few documentation errors) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
davidtwco
added
the
A-translation
calebcartwright
pushed a commit
to calebcartwright/rust
that referenced
this pull request
Jan 24, 2023
…imulacrum triagebot: add translation-related mention groups - Move some code around so that triagebot can ping relevant parties when translation logic is modified. - Add mention groups to triagebot for translation-related files/folders. - Auto-label pull requests with changes to translation-related files/folders with `A-translation`. r? `@Mark-Simulacrum`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A-translation.r? @Mark-Simulacrum