Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

rustc_target: Add some more target spec sanity checking #100537

Merged
merged 4 commits into from
Sep 1, 2022
Merged

rustc_target: Add some more target spec sanity checking #100537

merged 4 commits into from
Sep 1, 2022

Conversation

petrochenkov
Copy link
Contributor

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 14, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2022
@bors

This comment was marked as resolved.

# to view
@petrochenkov
Copy link
Contributor Author

@rustbot ready

@rust-log-analyzer

This comment has been minimized.

# to view
@rust-log-analyzer

This comment was marked as resolved.

# to view
@oli-obk
Copy link
Contributor

oli-obk commented Aug 29, 2022

@bors r+ rollup=never (for bisectability)

@bors
Copy link
Contributor

bors commented Aug 29, 2022

📌 Commit f7eb7ef has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2022
@bors
Copy link
Contributor

bors commented Sep 1, 2022

⌛ Testing commit f7eb7ef with merge aa857eb...

@bors
Copy link
Contributor

bors commented Sep 1, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing aa857eb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2022
@bors bors merged commit aa857eb into rust-lang:master Sep 1, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 1, 2022
This was referenced Sep 1, 2022
Merged
Merged
Closed
Closed
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aa857eb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.5% [3.1%, 5.9%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.3% [-4.3%, -4.3%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@asensio-project asensio-project mentioned this pull request Sep 3, 2022
Closed
@nicholasbishop nicholasbishop mentioned this pull request Sep 4, 2022
Merged
nicholasbishop added a commit to nicholasbishop/rust that referenced this pull request Sep 9, 2022
@nicholasbishop
Use RelocModel::Pic for UEFI targets
54d9ba8 
In rust-lang#100537, the relocation model
for UEFI targets was changed from PIC (the default value) to
static. There was some dicussion of this change here:
rust-lang#100537 (comment)

It turns out that this can cause compilation to fail as described in
rust-lang#101377, so switch back to PIC.

Fixes rust-lang#101377
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 10, 2022
@matthiaskrgr
Rollup merge of rust-lang#101413 - nicholasbishop:bishop-remove-uefi-…
857a43d 
…static-reloc, r=petrochenkov

Use RelocModel::Pic for UEFI targets

In rust-lang#100537, the relocation model for UEFI targets was changed from PIC (the default value) to
static. There was some dicussion of this change here: rust-lang#100537 (comment)

It turns out that this can cause compilation to fail as described in rust-lang#101377, so switch back to PIC.

Fixes rust-lang#101377
RalfJung
RalfJung reviewed Nov 24, 2024
View reviewed changes
compiler/rustc_target/src/spec/tests/tests_impl.rs
Comment on lines +151 to +153
if self.relocation_model == RelocModel::Pic {
assert!(self.dynamic_linking || self.position_independent_executables);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requirement is a bit odd since our default values for target options violate it -- the default relocation model is PIC, but the default for dynamic_linking and position_independent_executables is false. This is causing some trouble in #133409.

@RalfJung RalfJung mentioned this pull request Nov 25, 2024
Open
@petrochenkov petrochenkov deleted the piccheck branch February 22, 2025 18:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alessandrod alessandrod alessandrod left review comments

@RalfJung RalfJung RalfJung left review comments

@dvdhrm dvdhrm dvdhrm left review comments

@atopia atopia atopia left review comments

@marysaka marysaka marysaka left review comments

@ManuelvOK ManuelvOK ManuelvOK left review comments

@Ayush1325 Ayush1325 Ayush1325 left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.