translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1 #100753

beowolx · 2022-08-19T13:36:11Z

Description

This is the first PR for the migration of the module rustc_session. You can follow my progress here.

The PR migrates the files cgu_reuse_tracker and parse.rs to use SessionDiagnostic .

rust-highfive · 2022-08-19T13:36:14Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2022-08-19T13:36:14Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank

compiler-errors · 2022-08-19T18:07:23Z

Gonna mark this as a draft since it's WIP

beowolx · 2022-08-22T06:54:59Z

r? rust-lang/diagnostics

compiler/rustc_error_messages/locales/en-US/session.ftl

beowolx · 2022-08-22T09:12:46Z

@rustbot label -S-waiting-on-author +S-waiting-on-review

davidtwco · 2022-08-22T13:34:17Z

LGTM, waiting on #[fatal(..)] support landing

compiler/rustc_session/src/cgu_reuse_tracker.rs

beowolx · 2022-08-23T18:22:52Z

@rustbot label -S-waiting-on-author +S-waiting-on-review

…grate-session, r=davidtwco translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1 ## Description This is the first PR for the migration of the module `rustc_session`. You can follow my progress [here](rust-lang#100717 (comment)). The PR migrates the files `cgu_reuse_tracker` and `parse.rs` to use `SessionDiagnostic `.

This commit migrates the errors that indicates an incorrect CGU type and the fatal error that indicates that a CGU has not been correctly recorded

This commit migrates around 80% of the parse file to use SsessionDiagnostic We still have to migrate struct_err and struct_warn.

This commit migrates the errors in the function check_expected_reuse to use the new SessionDiagnostic. It also does some small refactor for the IncorrectCguReuseType to include the 'at least' word in the fluent translation file

davidtwco · 2022-08-30T16:09:05Z

@bors r-

Commits were added after approving, so will re-approve to avoid bors funniness (try to avoid doing this in future)

davidtwco · 2022-08-30T16:09:47Z

@bors r+

bors · 2022-08-30T16:09:49Z

📌 Commit 2c77f3e has been approved by davidtwco

It is now in the queue for this repository.

beowolx · 2022-08-30T16:57:33Z

@bors r-

Commits were added after approving, so will re-approve to avoid bors funniness (try to avoid doing this in future)

Ah sorry for that! It was just a rebase, I didn't know it would cause problems 🙈

…grate-session, r=davidtwco translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1 ## Description This is the first PR for the migration of the module `rustc_session`. You can follow my progress [here](rust-lang#100717 (comment)). The PR migrates the files `cgu_reuse_tracker` and `parse.rs` to use `SessionDiagnostic `.

Rollup of 7 pull requests Successful merges: - rust-lang#90946 (Ignore `reference`s in "Type::inner_def_id") - rust-lang#100730 (Migrate rustc_monomorphize to use SessionDiagnostic) - rust-lang#100753 (translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1) - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs) - rust-lang#101204 (rustdoc: Resugar async fn return type in `clean`, not `html`) - rust-lang#101216 (Use in-page links for sanitizer docs.) - rust-lang#101237 (fix into_iter on ZST) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…name-attr-warning-pt2, r=davidtwco translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2 # Description This is the second part of the `rustc_session` [migration](rust-lang#100717 (comment)). **Please only review this [commit](rust-lang@5018581) that belongs to the part 2. The other ones are from the PR [rust-lang#100753](rust-lang#100753) that is not yet merged.** In this PR, we migrate the files `session.rs` and `config.rs`. Please not that we have to `allow` the lints rules in some functions from `session.rs` because they are (at least I believe) part of the diagnostic machinery.

rust-highfive assigned nagisa Aug 19, 2022

rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 19, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2022

compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2022

This comment has been minimized.

# to view

compiler-errors marked this pull request as draft August 19, 2022 18:07

This comment has been minimized.

# to view

beowolx changed the title ~~translations(rustc_session): migrates completely rustc_session~~ translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 1 Aug 22, 2022

beowolx marked this pull request as ready for review August 22, 2022 06:54

rust-highfive assigned TaKO8Ki and unassigned nagisa Aug 22, 2022

This comment has been minimized.

# to view

beowolx changed the title ~~translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 1~~ translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 1 Aug 22, 2022

Xiretza reviewed Aug 22, 2022

View reviewed changes

compiler/rustc_error_messages/locales/en-US/session.ftl Outdated Show resolved Hide resolved

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2022

beowolx mentioned this pull request Aug 22, 2022

Diagnostic Translation #100717

Open

84 tasks

davidtwco reviewed Aug 23, 2022

View reviewed changes

compiler/rustc_session/src/cgu_reuse_tracker.rs Outdated Show resolved Hide resolved

davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2022

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2022

Dylan-DPC mentioned this pull request Aug 25, 2022

Rollup of 7 pull requests #100985

Closed

Dylan-DPC mentioned this pull request Aug 25, 2022

Rollup of 9 pull requests #100997

Closed

beowolx added 3 commits August 26, 2022 16:10

translations(rustc_session): migrate the file cgu_reuse_tracker

706452e

This commit migrates the errors that indicates an incorrect CGU type and the fatal error that indicates that a CGU has not been correctly recorded

translations(rustc_session): migrate 80% of the file parse.rs

d5262a9

This commit migrates around 80% of the parse file to use SsessionDiagnostic We still have to migrate struct_err and struct_warn.

translations(rustc_session): migrate check_expected_reuse

2c77f3e

This commit migrates the errors in the function check_expected_reuse to use the new SessionDiagnostic. It also does some small refactor for the IncorrectCguReuseType to include the 'at least' word in the fluent translation file

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 30, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 30, 2022

beowolx mentioned this pull request Aug 30, 2022

translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2 #101041

Merged

GuillaumeGomez mentioned this pull request Aug 31, 2022

Rollup of 6 pull requests #101233

Closed

RalfJung mentioned this pull request Aug 31, 2022

Rollup of 7 pull requests #101238

Merged

bors merged commit 24922b7 into rust-lang:master Aug 31, 2022

rustbot added this to the 1.65.0 milestone Aug 31, 2022

beowolx deleted the translation-migrate-session branch August 31, 2022 19:15

compiler-errors mentioned this pull request Dec 18, 2022

rustc_session: remove dead code from check_expected_reuse() #105865

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1 #100753

translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1 #100753

Uh oh!

beowolx commented Aug 19, 2022 •

edited

Loading

Uh oh!

rust-highfive commented Aug 19, 2022

Uh oh!

rustbot commented Aug 19, 2022

Uh oh!

This comment has been minimized.

compiler-errors commented Aug 19, 2022

Uh oh!

This comment has been minimized.

beowolx commented Aug 22, 2022

Uh oh!

This comment has been minimized.

Uh oh!

beowolx commented Aug 22, 2022

Uh oh!

davidtwco commented Aug 22, 2022

Uh oh!

Uh oh!

beowolx commented Aug 23, 2022

Uh oh!

davidtwco commented Aug 30, 2022

Uh oh!

davidtwco commented Aug 30, 2022

Uh oh!

bors commented Aug 30, 2022

Uh oh!

beowolx commented Aug 30, 2022

Uh oh!

Uh oh!

translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 1 #100753

translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 1 #100753

Uh oh!

Conversation

beowolx commented Aug 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

rust-highfive commented Aug 19, 2022

Uh oh!

rustbot commented Aug 19, 2022

Uh oh!

This comment has been minimized.

compiler-errors commented Aug 19, 2022

Uh oh!

This comment has been minimized.

beowolx commented Aug 22, 2022

Uh oh!

This comment has been minimized.

Uh oh!

beowolx commented Aug 22, 2022

Uh oh!

davidtwco commented Aug 22, 2022

Uh oh!

Uh oh!

beowolx commented Aug 23, 2022

Uh oh!

davidtwco commented Aug 30, 2022

Uh oh!

davidtwco commented Aug 30, 2022

Uh oh!

bors commented Aug 30, 2022

Uh oh!

beowolx commented Aug 30, 2022

Uh oh!

Uh oh!

translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1 #100753

translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1 #100753

beowolx commented Aug 19, 2022 •

edited

Loading