Skip to content

Suggest moving redundant generic args of an assoc fn to its trait #100838

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 1, 2022
Merged

Suggest moving redundant generic args of an assoc fn to its trait #100838

merged 4 commits into from
Sep 1, 2022

Conversation

hkmatsumoto
Copy link
Member

Closes #89064

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 21, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2022
@hkmatsumoto hkmatsumoto added the A-diagnostics Area: Messages for errors, warnings, and lints label Aug 21, 2022
davidtwco
davidtwco reviewed Aug 22, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, I like this change, I've left some suggestions that might help in improving this a little.

@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2022
@hkmatsumoto hkmatsumoto force-pushed the move-gen-args-to-trait-when-appropriate branch from e561432 to 2fd8577 Compare August 28, 2022 07:03
@hkmatsumoto hkmatsumoto force-pushed the move-gen-args-to-trait-when-appropriate branch from 2fd8577 to 722d136 Compare August 28, 2022 07:05
@hkmatsumoto hkmatsumoto marked this pull request as ready for review August 28, 2022 07:06
@hkmatsumoto hkmatsumoto added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 28, 2022
@hkmatsumoto hkmatsumoto requested a review from davidtwco August 28, 2022 07:07
@rust-log-analyzer

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 31, 2022

📌 Commit 1529137 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 31, 2022
@matthiaskrgr
Rollup merge of rust-lang#100838 - hkmatsumoto:move-gen-args-to-trait…
d957090 
…-when-appropriate, r=davidtwco

Suggest moving redundant generic args of an assoc fn to its trait

Closes rust-lang#89064
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 31, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 31, 2022
@matthiaskrgr
Rollup merge of rust-lang#100838 - hkmatsumoto:move-gen-args-to-trait…
2d7644a 
…-when-appropriate, r=davidtwco

Suggest moving redundant generic args of an assoc fn to its trait

Closes rust-lang#89064
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 31, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 31, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2022
@bors
Auto merge of rust-lang#101249 - matthiaskrgr:rollup-wahnoz8, r=matth…
db00199 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#100787 (Pretty printing give proper error message without panic)
 - rust-lang#100838 (Suggest moving redundant generic args of an assoc fn to its trait)
 - rust-lang#100844 (migrate rustc_query_system to use SessionDiagnostic)
 - rust-lang#101140 (Update Clippy)
 - rust-lang#101161 (Fix uintended diagnostic caused by `drain(..)`)
 - rust-lang#101165 (Use more `into_iter` rather than `drain(..)`)
 - rust-lang#101229 (Link “? operator” to relevant chapter in The Book)
 - rust-lang#101230 (lint: avoid linting diag functions with diag lints)
 - rust-lang#101236 (Avoid needless buffer zeroing in `std::sys::windows::fs`)
 - rust-lang#101240 (Fix a typo on `wasm64-unknown-unknown` doc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2af2cda into rust-lang:master Sep 1, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 1, 2022
@compiler-errors compiler-errors mentioned this pull request Sep 5, 2022
Merged
@steffahn steffahn mentioned this pull request Sep 5, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 6, 2022
@Dylan-DPC
Rollup merge of rust-lang#101427 - compiler-errors:issue-101421, r=cj…
8936211 
…gillot

Fix ICE, generalize 'move generics to trait' suggestion for >0 non-rcvr arguments

Fixes rust-lang#101421
cc rust-lang#100838
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 9, 2022
@bors
Auto merge of rust-lang#101249 - matthiaskrgr:rollup-wahnoz8, r=matth…
5b784f8 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#100787 (Pretty printing give proper error message without panic)
 - rust-lang#100838 (Suggest moving redundant generic args of an assoc fn to its trait)
 - rust-lang#100844 (migrate rustc_query_system to use SessionDiagnostic)
 - rust-lang#101140 (Update Clippy)
 - rust-lang#101161 (Fix uintended diagnostic caused by `drain(..)`)
 - rust-lang#101165 (Use more `into_iter` rather than `drain(..)`)
 - rust-lang#101229 (Link “? operator” to relevant chapter in The Book)
 - rust-lang#101230 (lint: avoid linting diag functions with diag lints)
 - rust-lang#101236 (Avoid needless buffer zeroing in `std::sys::windows::fs`)
 - rust-lang#101240 (Fix a typo on `wasm64-unknown-unknown` doc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

Suggest annotating traits rather than methods when appropriate
6 participants
@hkmatsumoto @rust-highfive @rust-log-analyzer @davidtwco @bors @rustbot