Skip to content

Migrate part of rustc_infer to session diagnostic #100843

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Aug 29, 2022

Conversation

IntQuant
Copy link
Contributor

No description provided.

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 21, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2022
@IntQuant IntQuant force-pushed the issue-100717-infer branch from 817803b to d199838 Compare August 21, 2022 18:25
@IntQuant
Copy link
Contributor Author

@rustbot label +A-translation

r? rust-lang/diagnostics
cc #100717

@IntQuant IntQuant force-pushed the issue-100717-infer branch from 51c18fa to 74f9973 Compare August 23, 2022 12:34
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, thanks for working on it, I've left a couple comments.

@davidtwco
Copy link
Member

r? @davidtwco

@davidtwco davidtwco mentioned this pull request Aug 23, 2022
84 tasks
@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2022
@IntQuant IntQuant changed the title Migrate rustc_infer to session diagnostic Migrate part of rustc_infer to session diagnostic Aug 24, 2022
@IntQuant IntQuant marked this pull request as ready for review August 24, 2022 13:38
@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Some changes occurred in need_type_info.rs

cc @lcnr

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 24, 2022

📌 Commit e1765a9 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2022
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 26, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Aug 26, 2022

📌 Commit e1765a9 has been approved by compiler-errors

It is now in the queue for this repository.

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 28, 2022
…piler-errors

Migrate part of rustc_infer to session diagnostic
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 28, 2022
…piler-errors

Migrate part of rustc_infer to session diagnostic
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 28, 2022
…piler-errors

Migrate part of rustc_infer to session diagnostic
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 28, 2022
…piler-errors

Migrate part of rustc_infer to session diagnostic
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 28, 2022
…piler-errors

Migrate part of rustc_infer to session diagnostic
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 29, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#94890 (Support parsing IP addresses from a byte string)
 - rust-lang#96334 (socket `set_mark` addition.)
 - rust-lang#99027 (Replace `Body::basic_blocks()` with field access)
 - rust-lang#100437 (Improve const mismatch `FulfillmentError`)
 - rust-lang#100843 (Migrate part of rustc_infer to session diagnostic)
 - rust-lang#100897 (extra sanity check against consts pointing to mutable memory)
 - rust-lang#100959 (translations: rename warn_ to warning)
 - rust-lang#101111 (Use the declaration's SourceInfo for FnEntry retags, not the outermost)
 - rust-lang#101116 ([rustdoc] Remove Attrs type alias)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a3c965f into rust-lang:master Aug 29, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants