-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Migrate part of rustc_infer to session diagnostic #100843
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. Please see the contribution instructions for more information. |
817803b
to
d199838
Compare
Those are basically the same but the first one seems to fit better
51c18fa
to
74f9973
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, thanks for working on it, I've left a couple comments.
r? @davidtwco |
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki Some changes occurred in need_type_info.rs cc @lcnr |
@bors r+ |
@bors r+ |
💡 This pull request was already approved, no need to approve it again.
|
…piler-errors Migrate part of rustc_infer to session diagnostic
…piler-errors Migrate part of rustc_infer to session diagnostic
…piler-errors Migrate part of rustc_infer to session diagnostic
…piler-errors Migrate part of rustc_infer to session diagnostic
…piler-errors Migrate part of rustc_infer to session diagnostic
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#94890 (Support parsing IP addresses from a byte string) - rust-lang#96334 (socket `set_mark` addition.) - rust-lang#99027 (Replace `Body::basic_blocks()` with field access) - rust-lang#100437 (Improve const mismatch `FulfillmentError`) - rust-lang#100843 (Migrate part of rustc_infer to session diagnostic) - rust-lang#100897 (extra sanity check against consts pointing to mutable memory) - rust-lang#100959 (translations: rename warn_ to warning) - rust-lang#101111 (Use the declaration's SourceInfo for FnEntry retags, not the outermost) - rust-lang#101116 ([rustdoc] Remove Attrs type alias) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
No description provided.