Skip to content

Migrate rustc_driver to SessionDiagnostic #100890

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 27, 2022
Merged

Migrate rustc_driver to SessionDiagnostic #100890

merged 6 commits into from
Aug 27, 2022

Conversation

adriantombu
Copy link
Contributor

First timer noob here 👋🏽 I'm having a problem understanding how I can retrieve the span, and how to properly construct the error structs to avoid the current compilation errors.

Any help pointing me in the right direction would be much appreciated 🙌🏽

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 22, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
davidtwco
davidtwco requested changes Aug 23, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, I've left some pointers.

@davidtwco davidtwco marked this pull request as draft August 23, 2022 13:27
@davidtwco davidtwco changed the title WIP: Migrate rustc_driver to SessionDiagnostic Migrate rustc_driver to SessionDiagnostic Aug 23, 2022
@davidtwco
Copy link
Member

r? @davidtwco

@davidtwco davidtwco mentioned this pull request Aug 23, 2022
Open
84 tasks
@davidtwco
Copy link
Member

We actually have a no merge policy, would you be able to rebase instead?

@adriantombu
Copy link
Contributor Author

Absolutely, sorry about that!

@rust-log-analyzer

This comment has been minimized.

# to view
@adriantombu adriantombu marked this pull request as ready for review August 23, 2022 17:27
davidtwco
davidtwco reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is almost ready, I've left another couple comments, thanks for your work on this

@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2022
@davidtwco
Copy link
Member

Use @rustbot ready when you've addressed the comments :)

@adriantombu
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
davidtwco
davidtwco reviewed Aug 25, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, one or two comments then we can land this.

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 26, 2022

📌 Commit d0401f7 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2022
@adriantombu
Copy link
Contributor Author

Thanks for your explanations and patience @davidtwco!

@compiler-errors
Copy link
Member

@bors rollup

@compiler-errors compiler-errors mentioned this pull request Aug 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2022
@bors
Auto merge of rust-lang#101064 - compiler-errors:rollup-fwm5m5f, r=co…
bb8a08f 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#100724 (Migrate ast lowering to session diagnostic)
 - rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`)
 - rust-lang#100738 (Diagnostics migr const eval)
 - rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs)
 - rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`)
 - rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword)
 - rust-lang#100836 (Migrate `rustc_attr` crate diagnostics)
 - rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic)
 - rust-lang#100900 (on `region_errors.rs`)

Failed merges:

 - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e7d870b into rust-lang:master Aug 27, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 27, 2022
@adriantombu adriantombu deleted the migrate_diagnostic_rustc_driver branch August 27, 2022 08:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
8 participants
@adriantombu @rust-highfive @rustbot @rust-log-analyzer @davidtwco @bors @compiler-errors @wesleywiser