Skip to content

Add a missing test case for impl generic mismatch #100945

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Aug 24, 2022

This suggestion use different span depending on whether the method has generics or not, so I added a test case about the method with some generics.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 24, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 24, 2022

📌 Commit 56f9e29 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 24, 2022
…impl-generic-mismatch, r=Dylan-DPC

Add a missing test case for impl generic mismatch

This suggestion use different span depending on whether the method has generics or not, so I added a test case about the method with some generics.
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2022
…iaskrgr

Rollup of 15 pull requests

Successful merges:

 - rust-lang#99993 (linker: Update some outdated comments)
 - rust-lang#100220 (Properly forward `ByRefSized::fold` to the inner iterator)
 - rust-lang#100826 (sugg: take into count the debug formatting)
 - rust-lang#100855 (Extra documentation for new formatting feature)
 - rust-lang#100888 (Coherence negative impls implied bounds)
 - rust-lang#100901 (Make some methods private)
 - rust-lang#100906 (Suggest alternatives when trying to mutate a `HashMap`/`BTreeMap` via indexing)
 - rust-lang#100912 (Diagnose missing includes in run-make tests)
 - rust-lang#100919 (Use par_body_owners for liveness)
 - rust-lang#100922 (Rewrite error index generator to greatly reduce the size of the pages)
 - rust-lang#100926 (Update README.md)
 - rust-lang#100930 (Use `--userns=keep-id` when "docker" is really podman)
 - rust-lang#100938 (rustdoc: remove unused CSS rule)
 - rust-lang#100940 (Do not suggest adding a bound to a opaque type)
 - rust-lang#100945 (Add a missing test case for impl generic mismatch)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fb88e25 into rust-lang:master Aug 24, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 24, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants