BindingAnnotation refactor

[camsteffen]

• ast::BindingMode is deleted and replaced with hir::BindingAnnotation (which is moved to ast)
• BindingAnnotation is changed from an enum to a tuple struct e.g. BindingAnnotation(ByRef::No, Mutability::Mut)
• Associated constants added for convenience BindingAnnotation::{NONE, REF, MUT, REF_MUT}

One goal is to make it more clear that BindingAnnotation merely represents syntax ref mut and not the actual binding mode. This was especially confusing since we had ast::BindingMode->hir::BindingAnnotation->thir::BindingMode.

I wish there were more symmetry between ByRef and Mutability (variant) naming (maybe Mutable::Yes?), and I also don't love how long the name BindingAnnotation is, but this seems like the best compromise. Ideas welcome.

[rust-highfive]

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

[bors]

☔ The latest upstream changes (presumably #101249) made this pull request unmergeable. Please resolve the merge conflicts.

[cjgillot]

@bors r+

[bors]

📌 Commit 9ea82d5 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9ea82d5 with merge b52a3be1828c81008d625765dc480609524da515...

[bors]

💔 Test failed - checks-actions

[camsteffen]

Looks quite spurious. @bors retry

[rust-log-analyzer]

The job dist-aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

      Memory: 14 GB
      System Firmware Version: VMW71.00V.13989454.B64.1906190538
      Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
      SMC Version (system): 2.8f0
      Serial Number (system): VMD61DXbtTDd
      Provisioning UDID: 4203018E-580F-C1B5-9525-B745CECA79EB

hw.ncpu: 3
hw.byteorder: 1234

[bors]

⌛ Testing commit 9ea82d5 with merge 6c358c6...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 6c358c6 to master...

[rust-timer]

Finished benchmarking commit (6c358c6): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.4%	[1.2%, 1.6%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	2.4%	[2.1%, 2.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³