Make `char::is_lowercase` and `char::is_uppercase` const #101401

mx00s · 2022-09-04T00:05:49Z

Implements #101400.

rust-highfive · 2022-09-04T00:05:52Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

src/tools/unicode-table-generator/src/raw_emitter.rs

fee1-dead

LGTM other than to make the types of constants &'static [T; N] instead of arrays to prevent copying.

library/core/src/unicode/unicode_data.rs

rustbot · 2022-09-04T15:02:03Z

Error: Label const-hack can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

Implements rust-lang#101400.

rustbot · 2022-09-04T15:13:53Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

mx00s · 2022-09-04T15:15:23Z

@rustbot label +T-libs-api -T-libs

mx00s · 2022-09-04T15:28:41Z

LGTM other than to make the types of constants &'static [T; N] instead of arrays to prevent copying.

Thank you for the helpful feedback and positive review, @fee1-dead.

I'm a new contributor, so I have a procedural question. Now that I've made the requested changes will you (or someone else) also have to tell bors r+ or will your GitHub approval be sufficient?

fee1-dead · 2022-09-04T15:49:39Z

Looks good to me, thanks for the PR. An r+ is needed to merge. The GitHub approval is not used for this purpose.

@bors r+

bors · 2022-09-04T15:49:40Z

📌 Commit 2b328ea has been approved by fee1-dead

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#101322 (Fix internal doc link) - rust-lang#101385 (updated description of File struct in std::fs) - rust-lang#101388 (Don't delay invalid LHS bug unless it will be covered by an error in `check_overloaded_binop`) - rust-lang#101394 (Forbid mixing `System` with direct sytem allocator calls) - rust-lang#101397 (rustdoc: remove redundant mobile-sized `.source nav:not(.sidebar).sub`) - rust-lang#101401 (Make `char::is_lowercase` and `char::is_uppercase` const) - rust-lang#101407 (Remove duplicated test (superseeded by search-form-elements.goml)) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…k, r=oli-obk Allow unauthenticated users to add the `const-hack` label Observed in rust-lang#101401. cc `@oli-obk`

…k, r=oli-obk Allow unauthenticated users to add the `const-hack` label Observed in rust-lang#101401. cc ``@oli-obk``

…k, r=oli-obk Allow unauthenticated users to add the `const-hack` label Observed in rust-lang#101401. cc ```@oli-obk```

…dtolnay switch unicode-data bitsets back to 'static' Back in rust-lang#101401, these were changed to `const` to make some functions `const fn`. However, `@dtolnay` was [not happy](rust-lang#101400 (comment)) about this. Meanwhile, `const fn` can access immutable statics like these, so we can change this back. Part of rust-lang#101400.

Rollup merge of rust-lang#131641 - RalfJung:unicode-bitset-static, r=dtolnay switch unicode-data bitsets back to 'static' Back in rust-lang#101401, these were changed to `const` to make some functions `const fn`. However, `@dtolnay` was [not happy](rust-lang#101400 (comment)) about this. Meanwhile, `const fn` can access immutable statics like these, so we can change this back. Part of rust-lang#101400.

rust-highfive assigned Mark-Simulacrum Sep 4, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 4, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2022

mx00s mentioned this pull request Sep 4, 2022

Tracking Issue for const_unicode_case_lookup #101400

Closed

3 tasks

ptrca reviewed Sep 4, 2022

View reviewed changes

src/tools/unicode-table-generator/src/raw_emitter.rs Outdated Show resolved Hide resolved

fee1-dead approved these changes Sep 4, 2022

View reviewed changes

klensy reviewed Sep 4, 2022

View reviewed changes

library/core/src/unicode/unicode_data.rs Outdated Show resolved Hide resolved

fee1-dead added the const-hack label Sep 4, 2022

mx00s added 2 commits September 4, 2022 08:07

Make char::is_lowercase and char::is_uppercase const

4a3e169

Implements rust-lang#101400.

Address feedback from PR rust-lang#101401

2b328ea

mx00s force-pushed the expand-const branch from f7dc7c2 to 2b328ea Compare September 4, 2022 15:13

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 4, 2022

Mark-Simulacrum assigned fee1-dead and unassigned Mark-Simulacrum Sep 4, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2022

matthiaskrgr mentioned this pull request Sep 4, 2022

Rollup of 7 pull requests #101411

Merged

bors merged commit d9bba11 into rust-lang:master Sep 4, 2022

rustbot added this to the 1.65.0 milestone Sep 4, 2022

mx00s deleted the expand-const branch September 4, 2022 22:19

fee1-dead mentioned this pull request Sep 12, 2022

Allow unauthenticated users to add the const-hack label #101724

Merged

RalfJung mentioned this pull request Oct 13, 2024

switch unicode-data bitsets back to 'static' #131641

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make `char::is_lowercase` and `char::is_uppercase` const #101401

Make `char::is_lowercase` and `char::is_uppercase` const #101401

Uh oh!

mx00s commented Sep 4, 2022

Uh oh!

rust-highfive commented Sep 4, 2022

Uh oh!

Uh oh!

fee1-dead left a comment

Uh oh!

Uh oh!

rustbot commented Sep 4, 2022

Uh oh!

rustbot commented Sep 4, 2022

Uh oh!

mx00s commented Sep 4, 2022

Uh oh!

mx00s commented Sep 4, 2022

Uh oh!

fee1-dead commented Sep 4, 2022 •

edited

Loading

Uh oh!

bors commented Sep 4, 2022

Uh oh!

Uh oh!

Make char::is_lowercase and char::is_uppercase const #101401

Make char::is_lowercase and char::is_uppercase const #101401

Uh oh!

Conversation

mx00s commented Sep 4, 2022

Uh oh!

rust-highfive commented Sep 4, 2022

Uh oh!

Uh oh!

fee1-dead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Sep 4, 2022

Uh oh!

rustbot commented Sep 4, 2022

Uh oh!

mx00s commented Sep 4, 2022

Uh oh!

mx00s commented Sep 4, 2022

Uh oh!

fee1-dead commented Sep 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Sep 4, 2022

Uh oh!

Uh oh!

Make `char::is_lowercase` and `char::is_uppercase` const #101401

Make `char::is_lowercase` and `char::is_uppercase` const #101401

fee1-dead commented Sep 4, 2022 •

edited

Loading