rustdoc: remove unused mobile CSS .rustdoc { flex-direction }
#101534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to MDN, [flex-direction] only applies to [flex containers], which are boxes with `display: flex` or `inline-flex`. However, the `.rustdoc` body container is not a flex-container on mobile. A few lines above, it's set to `display: block`, so this selector does not have any effect. [flex-direction]: https://developer.mozilla.org/en-US/docs/Web/CSS/flex-direction [flex containers]: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Flexible_Box_Layout/Basic_Concepts_of_Flexbox#the_flex_container
rustbot
added
the
T-rustdoc
|
r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Sep 7, 2022
|
Thanks! @bors r+ rollup |
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 7, 2022
…iaskrgr Rollup of 14 pull requests Successful merges: - rust-lang#101343 (Add -api-level to pm command) - rust-lang#101416 (stdio: Document no support for writing to non-blocking stdio/stderr) - rust-lang#101435 (Remove unnecessary `EMIT_MIR_FOR_EACH_BITWIDTH`) - rust-lang#101493 (Pass ImplTraitContext as &mut to avoid the need of ImplTraitContext::reborrow) - rust-lang#101502 (Do not suggest a semicolon for a macro without `!`) - rust-lang#101503 (Add debug calls) - rust-lang#101506 (rustdoc: remove unused CSS `#main-content > .since`) - rust-lang#101507 (rustdoc: remove unused CSS `#main-content > table td`) - rust-lang#101521 (Rustdoc-Json: More accurate struct type.) - rust-lang#101525 (Fix typo in pass_manager.rs) - rust-lang#101534 (rustdoc: remove unused mobile CSS `.rustdoc { flex-direction }`) - rust-lang#101535 (Fix error printing mistake in tidy) - rust-lang#101536 (Add documentation for Attr::is_doc_comment) - rust-lang#101538 (rustdoc: remove unused CSS `.content .methods > div`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MDN, flex-direction only applies to flex containers, which are boxes with
display: flexorinline-flex.However, the
.rustdocbody container is not a flex-container on mobile. A few lines above, it's set todisplay: block, so this selector does not have any effect.