Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stabilize waker_getters #101564

Closed
wants to merge 1 commit into from
Closed

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Sep 8, 2022

Close #96992
Close #87021

API summary:

// core::task
impl RawWaker {
    pub fn data(&self) -> *const ();
    pub fn vtable(&self) -> &'static RawWakerVTable;
}
impl Waker {
    pub fn as_raw(&self) -> &RawWaker;
}

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 8, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 8, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2022
@oxalica
Copy link
Contributor Author

oxalica commented Sep 8, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 8, 2022
@JohnTitor JohnTitor added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Nov 6, 2022
@TiddoLangerak
Copy link
Contributor

Has there been any progress on this recently? When could we expect this to land in stable?

@oxalica
Copy link
Contributor Author

oxalica commented Dec 7, 2022

Has there been any progress on this recently? When could we expect this to land in stable?

I'm not familiar with the formal stabilization steps. Seems we need an FCP.
r? rust-lang/libs-api

@rustbot rustbot assigned Amanieu and unassigned m-ou-se Dec 7, 2022
@Amanieu
Copy link
Member

Amanieu commented Dec 8, 2022

I raised a concern about the API in the tracking issue: #96992 (comment)

@oxalica oxalica marked this pull request as draft December 10, 2022 13:56
@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2023
@Dylan-DPC
Copy link
Member

@oxalica any updates on this?

@Dylan-DPC
Copy link
Member

Closing this as some concerns (listed on the tracking issue) still need to be resolved before we stabilise this so it's going to be a while.

@Dylan-DPC Dylan-DPC closed this May 16, 2023
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
needs-fcp This change is insta-stable, so needs a completed FCP to proceed. S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for waker_getters Feature: Provide getters of data and vtable pointer for RawWaker?
8 participants