Skip to content

Rollup of 6 pull requests #101603

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 9, 2022
Merged

Rollup of 6 pull requests #101603

merged 15 commits into from
Sep 9, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

5225225 and others added 15 commits August 14, 2022 10:37
@5225225
Enable eager checks for memory sanitizer
66dcf5d
@5225225
Emit noundef even for unoptimised code if msan is on
16525cc
@ehuss
Add const_extern_fn to 1.62 release notes.
ce3d526
@compiler-errors
Generator return doesn't need to be a lang item
2c94102
@compiler-errors
We can print futures with {integer} too
97668a5
@sanxiyn
Link UEFI target documentation from target list
52fd25d
fix the suggestion of format for asm_sub_register
28c62d2 
	modified:   compiler/rustc_typeck/src/check/intrinsicck.rs
	modified:   src/test/ui/asm/bad-template.aarch64_mirunsafeck.stderr
	modified:   src/test/ui/asm/bad-template.aarch64_thirunsafeck.stderr
	modified:   src/test/ui/asm/bad-template.x86_64_mirunsafeck.stderr
	modified:   src/test/ui/asm/bad-template.x86_64_thirunsafeck.stderr
	modified:   src/test/ui/asm/type-check-1.rs
	modified:   src/test/ui/asm/type-check-1.stderr
	modified:   src/test/ui/asm/x86_64/type-check-3.stderr
@GuillaumeGomez
Clean up themes a bit more
01fc131
@GuillaumeGomez
Add gui test for codeblocks tooltip colors
f9da510
@matthiaskrgr
Rollup merge of rust-lang#99207 - 5225225:msan-eager-checks, r=jackh726
6d20335 
Enable eager checks for memory sanitizer

Fixes rust-lang#99179
@matthiaskrgr
Rollup merge of rust-lang#101253 - lyming2007:issue-101163, r=Amanieu
0354eee 
fix the suggestion of format for asm_sub_register

	modified:   compiler/rustc_typeck/src/check/intrinsicck.rs
	modified:   src/test/ui/asm/bad-template.aarch64_mirunsafeck.stderr
	modified:   src/test/ui/asm/bad-template.aarch64_thirunsafeck.stderr
	modified:   src/test/ui/asm/bad-template.x86_64_mirunsafeck.stderr
	modified:   src/test/ui/asm/bad-template.x86_64_thirunsafeck.stderr
	modified:   src/test/ui/asm/type-check-1.rs
	modified:   src/test/ui/asm/type-check-1.stderr
	modified:   src/test/ui/asm/x86_64/type-check-3.stderr
@matthiaskrgr
Rollup merge of rust-lang#101450 - ehuss:relnotes-95346, r=Mark-Simul…
434591c 
…acrum

Add `const_extern_fn` to 1.62 release notes.

Adds rust-lang#95346 which did not get tagged with relnotes.

Closes rust-lang#101443
@matthiaskrgr
Rollup merge of rust-lang#101556 - compiler-errors:tweak-generator-pr…
bdfbc35 
…int, r=jackh726

Tweak future opaque ty pretty printing

1. The `Return` type of a generator doesn't need to be a lang item just for diagnostic printing of types
2. We shouldn't suppress the `Output = Ty` of a opaque future if the type is a int or float var.
@matthiaskrgr
Rollup merge of rust-lang#101563 - sanxiyn:doc-link-uefi, r=ehuss
1a61afd 
Link UEFI target documentation from target list

rust-lang#99760 added UEFI target documentation, but forgot to link it from the main target list.
@matthiaskrgr
Rollup merge of rust-lang#101593 - GuillaumeGomez:cleanup-theme-toolt…
8b78fa0 
…ip, r=notriddle

Cleanup themes (tooltip)

No changes in the UI. I used this opportunity to unify the dark theme with the others for the alpha parameter though.

r? `@notriddle`
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 9, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Collaborator

bors commented Sep 9, 2022

📌 Commit 8b78fa0 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 9, 2022
@bors
Copy link
Collaborator

bors commented Sep 9, 2022

⌛ Testing commit 8b78fa0 with merge 4a09adf...

@bors
Copy link
Collaborator

bors commented Sep 9, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 4a09adf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2022
@bors bors merged commit 4a09adf into rust-lang:master Sep 9, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 9, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#101593 5c8d9ddfda0760c9768f41ca2e83ce153d389d03
#101563 f21572e05585ea367e5b71d685916012f76c7667
#101556 bc4d6e25299e7e04c5e96c6db4f83ae93f9011a7
#101450 a7785de6b5a292807b33193a58d35afae80294b1
#101253 4766786d68908241dc0841bd4260475f7aa88e94
#99207 df63a2fdc81994e4dd9b4643bdf6fac644d5645f

previous master: ab32548539

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4a09adf): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.3% [-1.4%, -1.2%] 2
Improvements ✅
(secondary)		 -3.3% [-3.8%, -2.8%] 7
All ❌✅ (primary) -1.3% [-1.4%, -1.2%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.9% [1.9%, 1.9%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.9% [-4.3%, -3.6%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.0% [1.9%, 2.1%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.7% [-6.8%, -3.3%] 10
All ❌✅ (primary) - - 0

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@matthiaskrgr matthiaskrgr deleted the rollup-8y6kf20 branch October 9, 2022 00:31
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 27, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
9 participants
@matthiaskrgr @bors @rust-timer @rustbot @5225225 @ehuss @compiler-errors @sanxiyn @GuillaumeGomez