Skip to content

Do not suggest a placeholder to const and static without a type #101790

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2022
Merged

Do not suggest a placeholder to const and static without a type #101790

merged 1 commit into from
Sep 17, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Sep 14, 2022

Fixes #101755

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 14, 2022
@rust-highfive
Copy link
Contributor

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2022
compiler-errors
compiler-errors reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

@compiler-errors compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2022
@TaKO8Ki TaKO8Ki force-pushed the do-not-suggest-placeholder-to-const-and-static-without-type branch from 33af495 to 527292a Compare September 16, 2022 02:26
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Sep 16, 2022

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 16, 2022
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 17, 2022

📌 Commit 527292a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2022
@bors
Auto merge of rust-lang#101938 - Dylan-DPC:rollup-6vlohhs, r=Dylan-DPC
672831a 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#93628 (Stabilize `let else`)
 - rust-lang#98441 (Implement simd_as for pointers)
 - rust-lang#101790 (Do not suggest a placeholder to const and static without a type)
 - rust-lang#101807 (Disallow defaults on type GATs)
 - rust-lang#101915 (doc: fix redirected link in `/index.html`)
 - rust-lang#101931 (doc: Fix a typo in `Rc::make_mut` docstring)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4c64c14 into rust-lang:master Sep 17, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@compiler-errors compiler-errors Awaiting requested review from compiler-errors

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

placeholder _ is referred when there is a trait const with no type whatsoever.
5 participants
@TaKO8Ki @rust-highfive @compiler-errors @bors @rustbot