-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add Box<[T; N]>: TryFrom<Vec<T>>
#101837
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Box<[T; N]>: TryFrom<Vec<T>>
#101837
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
037c0c0
to
8ac373e
Compare
@rfcbot merge |
Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
We have `[T; N]: TryFrom<Vec<T>>` and `Box<[T; N]>: TryFrom<Box<[T]>>`, but not the combination. `vec.into_boxed_slice().try_into()` isn't quite a replacement for this, as that'll reallocate unnecessarily in the error case. **Insta-stable, so needs an FCP**
8ac373e
to
4d3a31c
Compare
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (06f049a): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Is it really a good idea to stabilize this when that likely makes it impossible to generalize it even if |
We have
[T; N]: TryFrom<Vec<T>>
(#76310) andBox<[T; N]>: TryFrom<Box<[T]>>
, but not this combination.vec.into_boxed_slice().try_into()
isn't quite a replacement for this, as that'll reallocate unnecessarily in the error case.Insta-stable, so needs an FCP
(I tried to make this work with
, A
, but that's disallowed because of#[fundamental]
#29635 (comment))