-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix the wording of help msg for bitwise not #101846
Conversation
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
@bors r- (CI hasn't yet returned green, if tests passes, I'l r+) |
Ehm shouldn't the phrase "bitwise not" only be used for integer types and the phrase "logical negation" be used for expressions that evaluate to a Boolean? |
You are right, let me tuning it more. |
For so, maybe the proper message is: We can try to testing whether next token is a number, but in other scenario, we can not get it accurate for boolean and number. |
r? @compiler-errors :) |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b79b7d8): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Fixes #101793