rustdoc: use more precise URLs for jump-to-definition links #101868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an example, this cuts down <https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_middle/ty/mod.rs.html> by about 11%. $ du -h new_mod.rs.html old_mod.rs.html 296K new_mod.rs.html 332K old_mod.rs.html
rustbot
added
the
T-rustdoc
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Sep 15, 2022
|
This is really great! Thanks a lot for that! @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2022
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#101494 (rustdoc mobile: move notable traits to return type) - rust-lang#101813 (Extend CSS check to CSS variables) - rust-lang#101825 (Fix back RPIT changes) - rust-lang#101843 (Suggest associated const for incorrect use of let in traits) - rust-lang#101859 (Slight vertical formatting) - rust-lang#101868 (rustdoc: use more precise URLs for jump-to-definition links) - rust-lang#101877 (rustdoc: remove no-op CSS `.block { padding: 0 }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example, this cuts down https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_middle/ty/mod.rs.html by about 11%.
Like #83237, but separate code since source links have a different URL structure.
Related to Zulip discussion and the jump-to-definition pre-RFC.