refactor: use grep -E/-F instead of fgrep/egrep #102092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
kxxt
force-pushed
the
patch-1
branch
2 times, most recently
from
690e0ad to
0acd8e7
Compare
|
What about BSD and Windows? Do they support |
It seems that BSD grep supports -E and -F. https://www.freebsd.org/cgi/man.cgi?query=grep&sektion=&n=1 Mingw grep supports these options, too. |
Mark-Simulacrum
added
S-waiting-on-author
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 14, 2022
refactor: use grep -E/-F instead of fgrep/egrep `egrep` and `fgrep` are obsolescent now. This PR updates all `egrep` and `fgrep` commands to `grep -E` and `grep -F`. Running egrep/fgrep command with grep v3.8 will output the following warning to stderr: ``` egrep: warning: egrep is obsolescent; using grep -E ``` - https://www.phoronix.com/news/GNU-Grep-3.8-Stop-egrep-fgrep - https://lists.gnu.org/archive/html/info-gnu/2022-09/msg00001.html
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#102092 (refactor: use grep -E/-F instead of fgrep/egrep) - rust-lang#102781 (Improved documentation for `std::io::Error`) - rust-lang#103017 (Avoid dropping TLS Key on sgx) - rust-lang#103039 (checktools: fix comments) - rust-lang#103045 (Remove leading newlines from integer primitive doc examples) - rust-lang#103047 (Update browser-ui-test version to fix some flaky tests) - rust-lang#103054 (Clean up rust-logo rustdoc GUI test) - rust-lang#103059 (Fix `Duration::{try_,}from_secs_f{32,64}(-0.0)`) - rust-lang#103067 (More alphabetical sorting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
egrepandfgrepare obsolescent now. This PR updates allegrepandfgrepcommands togrep -Eandgrep -F.Running egrep/fgrep command with grep v3.8 will output the following warning to stderr: