Add llvm-dis to the set of tools in ci-llvm
#102176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LLVM disassembler is needed for the test introduced in rust-lang#97550. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
rustbot
added
the
T-bootstrap
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Quoting @pietroalbini:
There is no change to any LLVM component, only an addition to the list of binaries. Looking at a previous bump that only updated the list of binaries (#94259 + #94023), the bump pointed to the other PR, so I assume this is fine (though the bump was merged later). But let me know if you prefer that the link points to itself. |
|
Seems fine. We could throw a random number in for roughly the same effect, I don't think I've followed that link yet... @bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 23, 2022
…ark-Simulacrum Add `llvm-dis` to the set of tools in `ci-llvm` The LLVM disassembler is needed for the test introduced in rust-lang#97550. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#101780 (Add a platform support document for Android) - rust-lang#102044 (Remove `RtlGenRandom` (take two)) - rust-lang#102081 (Adding ignore fuchsia tests for execvp (pre_exec)) - rust-lang#102082 (Adding ignore fuchsia non-applicable commands) - rust-lang#102146 (rustdoc: CSS prevent sidebar width change jank) - rust-lang#102152 (Calculate `ProjectionTy::trait_def_id` for return-position `impl Trait` in trait correctly) - rust-lang#102175 (Also require other subtrees to always build successfully) - rust-lang#102176 (Add `llvm-dis` to the set of tools in `ci-llvm`) - rust-lang#102188 (Update doc after renaming `fn is_zero`) - rust-lang#102199 (Improve rustdoc GUI tests) - rust-lang#102218 (Document some missing command-line arguments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LLVM disassembler is needed for the test introduced in #97550.
Signed-off-by: Miguel Ojeda ojeda@kernel.org