rustdoc: clean up .out-of-band/.in-band CSS
#102280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the `float: right` fallback from the main header, which hasn't been needed since IE11 support was dropped. * Remove `in-band` from low-level headers, which hasn't been needed since `.rightside` switched to `float: right` in 593d6d1 * Remove unreachable `.in-band > code, .in-band > .code-header` CSS, since the `in-band` class was attached to the `code-header` itself, not nested directly below it. * Use `rem` instead of `em` for code header margins. * This results in a slight change in spacing around impls and item-info, but since it makes it more consistent with the way methods are presented, it's probably fine.
rustbot
added
the
T-rustdoc
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Can you upload a demo please? That would make the checking much easier. |
|
Apart from my 2 comments, looks all good to me. Thanks for this improvement, it's really great! |
GuillaumeGomez
approved these changes
Sep 25, 2022
|
Thanks! r=me once CI pass. |
|
@bors r=GuillaumeGomez |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2022
…fee1-dead Rollup of 4 pull requests Successful merges: - rust-lang#101851 (Clean up (sub)diagnostic derives) - rust-lang#102244 (Only generate closure def id for async fns with body) - rust-lang#102263 (Clarify Iterator::rposition code example) - rust-lang#102280 (rustdoc: clean up `.out-of-band`/`.in-band` CSS) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
float: rightfallback from the main header, which hasn't been needed since IE11 support was dropped.Remove
in-bandfrom low-level headers, which hasn't been needed since.rightsideswitched tofloat: rightin 593d6d1Remove unreachable
.in-band > code, .in-band > .code-headerCSS, since thein-bandclass was attached to thecode-headeritself, not nested directly below it.Use
reminstead ofemfor code header margins.This results in a slight change in spacing around impls and item-info, but since it makes it more consistent with the way methods are presented, it's probably fine.
Preview: http://notriddle.com/notriddle-rustdoc-demos/band/std/fs/struct.File.html