-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Enable inline stack probes on PowerPC and SystemZ #102328
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
|
r? rust-lang/compiler |
|
||
#[no_mangle] | ||
pub fn foo() { | ||
// CHECK: @foo() unnamed_addr #0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
welp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (8a497b7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Enable inline stack probes on PowerPC and SystemZ The LLVM PowerPC and SystemZ targets have both supported `"probe-stack"="inline-asm"` for longer than our current minimum LLVM 13 requirement, so we can turn this on for all `powerpc`, `powerpc64`, `powerpc64le`, and `s390x` targets in Rust. These are all tier-2 or lower, so CI does not run their tests, but I have confirmed that their `linux-gnu` variants do pass on RHEL. cc rust-lang#43241
The LLVM PowerPC and SystemZ targets have both supported
"probe-stack"="inline-asm"
for longer than our current minimum LLVM 13 requirement, so we can turn this on for allpowerpc
,powerpc64
,powerpc64le
, ands390x
targets in Rust. These are all tier-2 or lower, so CI does not run their tests, but I have confirmed that theirlinux-gnu
variants do pass on RHEL.cc #43241