-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Change the parameter name of From::from to value
#102628
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon. Please see the contribution instructions for more information. |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Thanks for the PR! This makes good sense to me. It was probably only this way because it's a super-old trait and way back when it was possible to write @bors r+ rollup=always |
Change the parameter name of From::from to `value` The `From` trait is currently defined as: ```rust pub trait From<T>: Sized { fn from(_: T) -> Self; } ``` The name of the argument is `_`. I am proposing to change it to `value`, ie. ```rust pub trait From<T>: Sized { fn from(value: T) -> Self; } ``` This would be more consistent with the `TryFrom`, which looks like this: ```rust pub trait TryFrom<T>: Sized { type Error; fn try_from(value: T) -> Result<Self, Self::Error>; } ``` The reason for this proposal is twofold: 1. Consistency with the rest of the standard library. The `TryFrom` trait uses `value`, and no `From` implementation uses the default name (as it is quite useless). 2. When generating trait implementations with rust-analyzer/IntelliJ, the parameter name is copied, and it always has to be changed. Optionally, another name like `x` could be used. I only propose `value` for consistency with `TryFrom`. Changing parameter names is not a breaking change. Note: this was originally posted as an internals thread [here](https://internals.rust-lang.org/t/change-the-argument-name-of-from-from/17480)
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#102441 (Suggest unwrap_or_else when a closure is given) - rust-lang#102547 (Migrate CSS theme for search results) - rust-lang#102567 (Delay evaluating lint primary message until after it would be suppressed) - rust-lang#102624 (rustdoc: remove font family CSS on `.rustdoc-toggle summary::before`) - rust-lang#102628 (Change the parameter name of From::from to `value`) - rust-lang#102637 (Ignore fuchsia on two compiler tests) - rust-lang#102639 (Improve spans when splitting multi-char operator tokens for proc macros.) Failed merges: - rust-lang#102496 (Suggest `.into()` when all other coercion suggestions fail) r? `@ghost` `@rustbot` modify labels: rollup
The
From
trait is currently defined as:The name of the argument is
_
. I am proposing to change it tovalue
, ie.This would be more consistent with the
TryFrom
, which looks like this:The reason for this proposal is twofold:
TryFrom
trait usesvalue
, and noFrom
implementation uses the default name (as it is quite useless).Optionally, another name like
x
could be used. I only proposevalue
for consistency withTryFrom
.Changing parameter names is not a breaking change.
Note: this was originally posted as an internals thread here