Rollup of 8 pull requests #102850

JohnTitor · 2022-10-09T15:09:44Z

Successful merges:

fs::get_mode enable getting the data via fcntl/F_GETFL on major BSD #101118 (fs::get_mode enable getting the data via fcntl/F_GETFL on major BSD)
Add ptr::Alignment type #102072 (Add ptr::Alignment type)
rustdoc: remove hover gap in file picker #102799 (rustdoc: remove hover gap in file picker)
Show let-else suggestion on stable. #102820 (Show let-else suggestion on stable.)
rename ImplItemKind::TyAlias to ImplItemKind::Type #102829 (rename ImplItemKind::TyAlias to ImplItemKind::Type)
Don't use unnormalized type in Ty::fn_sig call in rustdoc clean_middle_ty #102831 (Don't use unnormalized type in Ty::fn_sig call in rustdoc clean_middle_ty)
Remove unnecessary lift/lift_to_tcx calls from rustdoc #102834 (Remove unnecessary lift/lift_to_tcx calls from rustdoc)
remove cfg(bootstrap) from Miri #102838 (remove cfg(bootstrap) from Miri)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

supporting this flag.

Essentially no new code here, just exposing the previously-`pub(crate)` `ValidAlign` type under the name from the ACP.

…ut` methods

…mulacrum fs::get_mode enable getting the data via fcntl/F_GETFL on major BSD supporting this flag.

Add `ptr::Alignment` type Essentially no new code here, just exposing the previously-`pub(crate)` `ValidAlign` type under the name from the ACP. ACP: rust-lang/libs-team#108 Tracking Issue: rust-lang#102070 r? ``@ghost``

rustdoc: remove hover gap in file picker Fixes rust-lang#100421 Before: <img width="385" alt="image" src="https://user-images.githubusercontent.com/29011024/194677087-fda2db3e-126d-47cf-8152-c554e3c25a54.png"> After: <img width="388" alt="image" src="https://user-images.githubusercontent.com/29011024/194676774-7a50ace9-4060-492e-849a-ad85d9132630.png"> longe module names also wrap nicely: <img width="389" alt="image" src="https://user-images.githubusercontent.com/29011024/194678516-f2497b3a-8d50-439b-9d69-3fa9fb43b84d.png"> Also if you zoom out very far, the arrows did move to the left, in relation to the text below. This is now also fixed. <img width="818" alt="image" src="https://user-images.githubusercontent.com/29011024/194677652-cfdf129d-f5db-4f26-ac3c-3d0853e89619.png"> CSS doesn't have a lot of controll over the `::marker` element, so now the `::after` element is used to draw the arrows. Now the whole line is clickable wihtout gaps.

… r=petrochenkov Show let-else suggestion on stable. The E0005 error message has a suggestion to use let-else. Now that let-else is stabilized, I think this message should be included on non-nightly toolchains. I suspect this was just an oversight from rust-lang#93628. [`E0005.stderr`](https://github.com/ehuss/rust/blob/be1c7aad723126b2ea65543b4ceed54167b841a2/src/test/ui/error-codes/E0005.stderr#L22-L25) contains an example of what this suggestion looks like.

…ind, r=TaKO8Ki rename `ImplItemKind::TyAlias` to `ImplItemKind::Type` The naming of this variant seems inconsistent given that this is not really a "type alias", and the associated type variant for `TraitItemKind` is just called `Type`.

… r=jyn514 Don't use unnormalized type in `Ty::fn_sig` call in rustdoc `clean_middle_ty` Self-explanatory Fixes rust-lang#102828

…r=jyn514 Remove unnecessary `lift`/`lift_to_tcx` calls from rustdoc Not sure why they were here in the first place

remove cfg(bootstrap) from Miri Looks like this was forgotten in the bootstrap bump. r? `@oli-obk`

JohnTitor · 2022-10-09T15:10:00Z

@bors r+ p=8 rollup=never

bors · 2022-10-09T15:10:02Z

📌 Commit f59e8af has been approved by JohnTitor

It is now in the queue for this repository.

bors · 2022-10-09T18:15:29Z

⌛ Testing commit f59e8af with merge 81f3919...

bors · 2022-10-09T21:02:24Z

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing 81f3919 to master...

rust-timer · 2022-10-09T21:04:52Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#102838	aaeafb70b1ae7a4b060bcd7e5b5f2620b332ec5f
#102834	2c69689df060fb20315762356ce2eb184f7cdfd2
#102831	2fa0d0a00e2a9f645bbc56618d4563047ae8a162
#102829	b73d52aad10797938b34aaed950b407a7fa61b1b
#102820	5626d1449c3adee2edc56bfaa6c400586359b8cf
#102799	9d4ce1361d954433a4466989acc66755f1fc62bf
#102072	548d464e20d5051d5a33d831daedd4a0912f1cf0
#101118	5b5975cd61538164e38b93f4329dfac6060abaf3

previous master: 1b225414f3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-10-09T22:23:12Z

Finished benchmarking commit (81f3919): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-1.0%, -0.2%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[1.2%, 2.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-3.0%, -2.3%]	2
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	-2.7%	[-3.0%, -2.3%]	2

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

Rollup of 8 pull requests Successful merges: - rust-lang#101118 (fs::get_mode enable getting the data via fcntl/F_GETFL on major BSD) - rust-lang#102072 (Add `ptr::Alignment` type) - rust-lang#102799 (rustdoc: remove hover gap in file picker) - rust-lang#102820 (Show let-else suggestion on stable.) - rust-lang#102829 (rename `ImplItemKind::TyAlias` to `ImplItemKind::Type`) - rust-lang#102831 (Don't use unnormalized type in `Ty::fn_sig` call in rustdoc `clean_middle_ty`) - rust-lang#102834 (Remove unnecessary `lift`/`lift_to_tcx` calls from rustdoc) - rust-lang#102838 (remove cfg(bootstrap) from Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

devnexen and others added 19 commits August 28, 2022 10:43

fs::get_mode enable getting the data via fcntl/F_GETFL on major BSD

c8f73e7

supporting this flag.

Add ptr::Alignment type

585bcc6

Essentially no new code here, just exposing the previously-`pub(crate)` `ValidAlign` type under the name from the ACP.

Add rustc_allow_const_fn_unstable annotations to pre-existing `Layo…

e2d7cdc

…ut` methods

Derive Eq/PartialEq instead of manually implementing it

c158b7b

rustdoc: remove hover gap in file picker

468acca

Show let-else suggestion on stable.

be1c7aa

ImplItemKind::TyAlias => ImplItemKind::Type

70f3c79

Don't use unnormalized type in Ty::fn_sig

7dedb91

rustdoc: fix file picker marker renders twice on ios

7fdce64

Remove unnecessary lift calls from rustdoc

9a4d4d5

remove cfg(bootstrap) from Miri

d47d390

Rollup merge of rust-lang#101118 - devnexen:fs_getmode_bsd, r=Mark-Si…

d0f1cf5

…mulacrum fs::get_mode enable getting the data via fcntl/F_GETFL on major BSD supporting this flag.

Rollup merge of rust-lang#102831 - compiler-errors:rustdoc-norm-oops,…

0a9b09f

… r=jyn514 Don't use unnormalized type in `Ty::fn_sig` call in rustdoc `clean_middle_ty` Self-explanatory Fixes rust-lang#102828

Rollup merge of rust-lang#102834 - compiler-errors:unnecessary-lift, …

deb93ca

…r=jyn514 Remove unnecessary `lift`/`lift_to_tcx` calls from rustdoc Not sure why they were here in the first place

Rollup merge of rust-lang#102838 - RalfJung:miri-bootstrap, r=oli-obk

f59e8af

remove cfg(bootstrap) from Miri Looks like this was forgotten in the bootstrap bump. r? `@oli-obk`

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 9, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 9, 2022

bors merged commit 81f3919 into rust-lang:master Oct 9, 2022

rustbot added this to the 1.66.0 milestone Oct 9, 2022

JohnTitor deleted the rollup-lze1w03 branch October 10, 2022 00:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests #102850

Rollup of 8 pull requests #102850

Uh oh!

JohnTitor commented Oct 9, 2022

Uh oh!

JohnTitor commented Oct 9, 2022

Uh oh!

bors commented Oct 9, 2022

Uh oh!

bors commented Oct 9, 2022

Uh oh!

bors commented Oct 9, 2022

Uh oh!

rust-timer commented Oct 9, 2022

Uh oh!

rust-timer commented Oct 9, 2022

Uh oh!

Uh oh!

Rollup of 8 pull requests #102850

Rollup of 8 pull requests #102850

Uh oh!

Conversation

JohnTitor commented Oct 9, 2022

Uh oh!

JohnTitor commented Oct 9, 2022

Uh oh!

bors commented Oct 9, 2022

Uh oh!

bors commented Oct 9, 2022

Uh oh!

bors commented Oct 9, 2022

Uh oh!

rust-timer commented Oct 9, 2022

Uh oh!

rust-timer commented Oct 9, 2022

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Uh oh!